Change signs of exported fields from ATM#675
Merged
Merged
Conversation
* send mean momentum fluxes to mediator w/ correct sign for coupling * fix variable alignment in module_block_data
This was referenced Jun 30, 2023
DusanJovic-NOAA
approved these changes
Aug 2, 2023
junwang-noaa
approved these changes
Aug 2, 2023
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the signs for the coupled fields exported to CMEPS by the ATM. These fields are the momentum fluxes, sensible and latent heat fluxes and the evaporative flux.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Testing was carried out using ufs-community/ufs-weather-model#1807. Full testing results are detailed there. In brief, in coupled and hafs tests, all baseline files are expected to be B4B with the exception of the mediator restart and history files. These files compare as different because the sign of the fields (but not the magnitude) has changed. All other tests reproduce.
Dependencies