Fix to allow quilting with non-factors for layout#192
Merged
Conversation
Collaborator
|
@chan-hoo just to confirm, you are not expecting this to change the results for thee regression tests, correct? |
Contributor
Author
|
You're correct. I think the regression tests would be set with factors for layout or quilting=false. |
Collaborator
Thanks, @chan-hoo. That's good to know. I'll pull this into release/public-v2 right away. This removes the urgency of the commit for the develop branches. |
chan-hoo
changed the title
DusanJovic-NOAA
approved these changes
Nov 23, 2020
junwang-noaa
approved these changes
Nov 23, 2020
climbfuji
approved these changes
Nov 23, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I don't see any of the comments that were to be removed, all good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the layout values (lx, ly) in the input file 'input.nml' are not factors of (npx-1) and (npy-1) respectively, quilting does not work.
Issue(s) addressed
Testing
It has passed the regression test on Hera.
It makes quilting work with non-factors for layout (two cases tested):