From 311657dcf8edb217c52409b8adabfc5c4a3441c8 Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Sat, 11 Feb 2023 22:24:04 +0000 Subject: [PATCH 01/10] cyc with ocn-ice --- jobs/rocoto/ocnanalbmat.sh | 2 +- parm/config/config.base.emc.dyn | 3 +++ ush/forecast_postdet.sh | 5 +++++ ush/load_ufsda_modules.sh | 3 ++- workflow/rocoto/workflow_tasks.py | 5 ++--- workflow/setup_expt.py | 8 ++++++++ 6 files changed, 21 insertions(+), 5 deletions(-) diff --git a/jobs/rocoto/ocnanalbmat.sh b/jobs/rocoto/ocnanalbmat.sh index f7ee7c1d4f7..e62db9115ad 100755 --- a/jobs/rocoto/ocnanalbmat.sh +++ b/jobs/rocoto/ocnanalbmat.sh @@ -13,7 +13,7 @@ export jobid="${job}.$$" ############################################################### # Execute the JJOB -#"${HOMEgfs}"/jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT +"${HOMEgfs}"/jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT echo "BMAT gets run here" status=$? exit "${status}" diff --git a/parm/config/config.base.emc.dyn b/parm/config/config.base.emc.dyn index 34c71de8d87..c31a1528524 100644 --- a/parm/config/config.base.emc.dyn +++ b/parm/config/config.base.emc.dyn @@ -308,6 +308,9 @@ export imp_physics=@IMP_PHYSICS@ export DO_JEDIVAR="NO" export DO_JEDIENS="NO" export DO_JEDIOCNVAR="NO" +if [[ ${DO_JEDIOCNVAR} = "YES" ]]; then + export MOM_IAU=true +fi # Hybrid related export DOHYBVAR="@DOHYBVAR@" diff --git a/ush/forecast_postdet.sh b/ush/forecast_postdet.sh index 6342b4ccba8..f536d41af87 100755 --- a/ush/forecast_postdet.sh +++ b/ush/forecast_postdet.sh @@ -769,6 +769,11 @@ MOM6_postdet() { ;; esac + # Link increment + if [[ "${MOM_IAU}" = "true" ]]; then + $NLN "${ROTDIR}/${CDUMP}.${PDY}/${cyc}/ocean/${CDUMP}.t${cyc}z.ocninc.nc" "${DATA}/INPUT/inc.nc" + fi + # Copy MOM6 fixed files $NCP -pf $FIXmom/$OCNRES/* $DATA/INPUT/ diff --git a/ush/load_ufsda_modules.sh b/ush/load_ufsda_modules.sh index d4e525c6133..e4e033651fb 100755 --- a/ush/load_ufsda_modules.sh +++ b/ush/load_ufsda_modules.sh @@ -1,7 +1,8 @@ #! /usr/bin/env bash ############################################################### -if [[ "${DEBUG_WORKFLOW:-NO}" == "NO" ]]; then +export DEBUG_WORKFLOW="${DEBUG_WORKFLOW:-NO}" +if [[ "${DEBUG_WORKFLOW}" == "NO" ]]; then echo "Loading modules quietly..." set +x fi diff --git a/workflow/rocoto/workflow_tasks.py b/workflow/rocoto/workflow_tasks.py index 2244504d3c2..8568817693b 100644 --- a/workflow/rocoto/workflow_tasks.py +++ b/workflow/rocoto/workflow_tasks.py @@ -649,9 +649,8 @@ def _fcst_cycled(self): dependencies = rocoto.create_dependency(dep=dep) if self.app_config.do_jediocnvar: - dep_dict = {'type': 'task', 'name': f'{self.cdump}ocnanalrun'} - dep = rocoto.add_dependency(dep_dict) - dependencies = rocoto.create_dependency(dep=dep) + dep_dict = {'type': 'task', 'name': f'{self.cdump}ocnanalpost'} + dependencies.append(rocoto.add_dependency(dep_dict)) if self.app_config.do_gldas and self.cdump in ['gdas']: dep_dict = {'type': 'task', 'name': f'{self.cdump}gldas'} diff --git a/workflow/setup_expt.py b/workflow/setup_expt.py index ef01bc9e525..9c0d3fbd314 100755 --- a/workflow/setup_expt.py +++ b/workflow/setup_expt.py @@ -120,6 +120,14 @@ def link_files_from_src_to_dst(src_dir, dst_dir): makedirs_if_missing(dst_dir) link_files_from_src_to_dst(src_dir, dst_dir) + # First 1/2 cycle needs a MOM6 increment + incdir = f'{inputs.cdump}.{idatestr[:8]}/{idatestr[8:]}' + incfile = f'{inputs.cdump}.t{idatestr[8:]}z.ocninc.nc' + src_file = os.path.join(inputs.icsdir, incdir, 'ocean', incfile) + dst_file = os.path.join(comrot, incdir, 'ocean', incfile) + makedirs_if_missing(os.path.join(comrot, incdir, 'ocean')) + os.symlink(src_file, dst_file) + # Link ice files if do_ice: detdir = f'{inputs.cdump}.{rdatestr[:8]}/{rdatestr[8:]}' From 364df4ee3ed8f6eb9850250a29a2649393fbdf38 Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Mon, 13 Feb 2023 18:40:56 -0500 Subject: [PATCH 02/10] Update ush/forecast_postdet.sh Co-authored-by: Rahul Mahajan --- ush/forecast_postdet.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ush/forecast_postdet.sh b/ush/forecast_postdet.sh index f536d41af87..23cc1348d0d 100755 --- a/ush/forecast_postdet.sh +++ b/ush/forecast_postdet.sh @@ -770,8 +770,13 @@ MOM6_postdet() { esac # Link increment - if [[ "${MOM_IAU}" = "true" ]]; then + if [[ "${DO_JEDIOCNVAR:-NO}" = "YES" ]]; then + if [[ ! -f "${ROTDIR}/${CDUMP}.${PDY}/${cyc}/ocean/${CDUMP}.t${cyc}z.ocninc.nc" ]]; then + echo "FATAL ERROR: Ocean increment not found, ABORT!" + exit 111 + fi $NLN "${ROTDIR}/${CDUMP}.${PDY}/${cyc}/ocean/${CDUMP}.t${cyc}z.ocninc.nc" "${DATA}/INPUT/inc.nc" + export MOM_IAU="true" fi # Copy MOM6 fixed files From 015e0bd462b7ccd049e5889fb64ffb790bfc6937 Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Mon, 13 Feb 2023 18:41:04 -0500 Subject: [PATCH 03/10] Update parm/config/config.base.emc.dyn Co-authored-by: Rahul Mahajan --- parm/config/config.base.emc.dyn | 3 --- 1 file changed, 3 deletions(-) diff --git a/parm/config/config.base.emc.dyn b/parm/config/config.base.emc.dyn index c31a1528524..34c71de8d87 100644 --- a/parm/config/config.base.emc.dyn +++ b/parm/config/config.base.emc.dyn @@ -308,9 +308,6 @@ export imp_physics=@IMP_PHYSICS@ export DO_JEDIVAR="NO" export DO_JEDIENS="NO" export DO_JEDIOCNVAR="NO" -if [[ ${DO_JEDIOCNVAR} = "YES" ]]; then - export MOM_IAU=true -fi # Hybrid related export DOHYBVAR="@DOHYBVAR@" From 19c474880a38b3859a282fd784c2270428f66dea Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Mon, 13 Feb 2023 19:05:11 -0500 Subject: [PATCH 04/10] addressed review comments --- parm/mom6/MOM_input_template_025 | 32 ++++++++++++++++++++++++++---- parm/mom6/MOM_input_template_050 | 34 +++++++++++++++++++++++++++----- parm/mom6/MOM_input_template_100 | 28 +++++++++++++++++++++++--- parm/mom6/MOM_input_template_500 | 6 ++++-- ush/forecast_postdet.sh | 2 +- ush/parsing_namelists_MOM6.sh | 8 ++++---- 6 files changed, 91 insertions(+), 19 deletions(-) diff --git a/parm/mom6/MOM_input_template_025 b/parm/mom6/MOM_input_template_025 index 3abbf2191bd..7ef27e21fec 100644 --- a/parm/mom6/MOM_input_template_025 +++ b/parm/mom6/MOM_input_template_025 @@ -406,7 +406,7 @@ GILL_EQUATORIAL_LD = True ! [Boolean] default = False ! radius, otherwise, if false, use Pedlosky's definition. These definitions ! differ by a factor of 2 in front of the beta term in the denominator. Gill's ! is the more appropriate definition. -INTERNAL_WAVE_SPEED_BETTER_EST = False ! [Boolean] default = True +INTERNAL_WAVE_SPEED_BETTER_EST = False ! [Boolean] default = True ! If true, use a more robust estimate of the first mode wave speed as the ! starting point for iterations. @@ -731,7 +731,7 @@ NSTAR = 0.06 ! [nondim] default = 0.2 ! The portion of the buoyant potential energy imparted by surface fluxes that is ! available to drive entrainment at the base of mixed layer when that energy is ! positive. -EPBL_MLD_BISECTION = True ! [Boolean] default = False +EPBL_MLD_BISECTION = True ! [Boolean] default = False ! If true, use bisection with the iterative determination of the self-consistent ! mixed layer depth. Otherwise use the false position after a maximum and ! minimum bound have been evaluated and the returned value or bisection before @@ -833,6 +833,30 @@ ENERGYSAVEDAYS = 1.00 ! [days] default = 1.0 ! === module ocean_model_init === +! === module MOM_oda_incupd === +ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False + ! If true, oda incremental updates will be applied + ! everywhere in the domain. +ODA_INCUPD_FILE = "inc.nc" ! The name of the file with the T,S,h increments. + +ODA_TEMPINC_VAR = "Temp" ! default = "ptemp_inc" + ! The name of the potential temperature inc. variable in + ! ODA_INCUPD_FILE. +ODA_SALTINC_VAR = "Salt" ! default = "sal_inc" + ! The name of the salinity inc. variable in + ! ODA_INCUPD_FILE. +ODA_THK_VAR = "h" ! default = "h" + ! The name of the int. depth inc. variable in + ! ODA_INCUPD_FILE. +ODA_INCUPD_UV = false ! +!ODA_UINC_VAR = "u" ! default = "u_inc" + ! The name of the zonal vel. inc. variable in + ! ODA_INCUPD_UV_FILE. +!ODA_VINC_VAR = "v" ! default = "v_inc" + ! The name of the meridional vel. inc. variable in + ! ODA_INCUPD_UV_FILE. +ODA_INCUPD_NHOURS = @[ODA_INCUPD_NHOURS] ! default=3.0 + ! === module MOM_surface_forcing === OCEAN_SURFACE_STAGGER = "A" ! default = "C" ! A case-insensitive character string to indicate the @@ -868,8 +892,8 @@ LIQUID_RUNOFF_FROM_DATA = @[MOM6_RIVER_RUNOFF] ! [Boolean] default = False ! the data_table using the component name 'OCN'. ! === module ocean_stochastics === DO_SPPT = @[DO_OCN_SPPT] ! [Boolean] default = False - ! If true perturb the diabatic tendencies in MOM_diabadic_driver -PERT_EPBL = @[PERT_EPBL] ! [Boolean] default = False + ! If true perturb the diabatic tendencies in MOM_diabadic_driver +PERT_EPBL = @[PERT_EPBL] ! [Boolean] default = False ! If true perturb the KE dissipation and destruction in MOM_energetic_PBL ! === module MOM_restart === RESTART_CHECKSUMS_REQUIRED = False diff --git a/parm/mom6/MOM_input_template_050 b/parm/mom6/MOM_input_template_050 index 4e703a4bfdb..62a7e1c6d4c 100644 --- a/parm/mom6/MOM_input_template_050 +++ b/parm/mom6/MOM_input_template_050 @@ -419,7 +419,7 @@ GILL_EQUATORIAL_LD = True ! [Boolean] default = False ! radius, otherwise, if false, use Pedlosky's definition. These definitions ! differ by a factor of 2 in front of the beta term in the denominator. Gill's ! is the more appropriate definition. -INTERNAL_WAVE_SPEED_BETTER_EST = False ! [Boolean] default = True +INTERNAL_WAVE_SPEED_BETTER_EST = False ! [Boolean] default = True ! If true, use a more robust estimate of the first mode wave speed as the ! starting point for iterations. @@ -757,7 +757,7 @@ MSTAR2_COEF1 = 0.29 ! [nondim] default = 0.3 MSTAR2_COEF2 = 0.152 ! [nondim] default = 0.085 ! Coefficient in computing mstar when only rotation limits the total mixing ! (used if EPBL_MSTAR_SCHEME = OM4) -EPBL_MLD_BISECTION = True ! [Boolean] default = False +EPBL_MLD_BISECTION = True ! [Boolean] default = False ! If true, use bisection with the iterative determination of the self-consistent ! mixed layer depth. Otherwise use the false position after a maximum and ! minimum bound have been evaluated and the returned value or bisection before @@ -858,8 +858,32 @@ USE_NEUTRAL_DIFFUSION = True ! [Boolean] default = False ! If true, enables the neutral diffusion module. ! === module ocean_model_init === - RESTART_CHECKSUMS_REQUIRED = False + +! === module MOM_oda_incupd === +ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False + ! If true, oda incremental updates will be applied + ! everywhere in the domain. +ODA_INCUPD_FILE = "inc.nc" ! The name of the file with the T,S,h increments. + +ODA_TEMPINC_VAR = "Temp" ! default = "ptemp_inc" + ! The name of the potential temperature inc. variable in + ! ODA_INCUPD_FILE. +ODA_SALTINC_VAR = "Salt" ! default = "sal_inc" + ! The name of the salinity inc. variable in + ! ODA_INCUPD_FILE. +ODA_THK_VAR = "h" ! default = "h" + ! The name of the int. depth inc. variable in + ! ODA_INCUPD_FILE. +ODA_INCUPD_UV = false ! +!ODA_UINC_VAR = "u" ! default = "u_inc" + ! The name of the zonal vel. inc. variable in + ! ODA_INCUPD_UV_FILE. +!ODA_VINC_VAR = "v" ! default = "v_inc" + ! The name of the meridional vel. inc. variable in + ! ODA_INCUPD_UV_FILE. +ODA_INCUPD_NHOURS = @[ODA_INCUPD_NHOURS] ! default=3.0 + ! === module MOM_lateral_boundary_diffusion === ! This module implements lateral diffusion of tracers near boundaries @@ -913,8 +937,8 @@ LIQUID_RUNOFF_FROM_DATA = @[MOM6_RIVER_RUNOFF] ! [Boolean] default = False ! the data_table using the component name 'OCN'. ! === module ocean_stochastics === DO_SPPT = @[DO_OCN_SPPT] ! [Boolean] default = False - ! If true perturb the diabatic tendencies in MOM_diabadic_driver -PERT_EPBL = @[PERT_EPBL] ! [Boolean] default = False + ! If true perturb the diabatic tendencies in MOM_diabadic_driver +PERT_EPBL = @[PERT_EPBL] ! [Boolean] default = False ! If true perturb the KE dissipation and destruction in MOM_energetic_PBL ! === module MOM_restart === diff --git a/parm/mom6/MOM_input_template_100 b/parm/mom6/MOM_input_template_100 index 1aedf9e7f19..e138f76818d 100644 --- a/parm/mom6/MOM_input_template_100 +++ b/parm/mom6/MOM_input_template_100 @@ -76,7 +76,7 @@ SAVE_INITIAL_CONDS = False ! [Boolean] default = False ! If true, write the initial conditions to a file given by IC_OUTPUT_FILE. ! === module MOM_oda_incupd === -ODA_INCUPD = @[MOM_IAU] ! [Boolean] default = False +ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False ! If true, oda incremental updates will be applied ! everywhere in the domain. ODA_INCUPD_FILE = "mom6_increment.nc" ! The name of the file with the T,S,h increments. @@ -97,7 +97,7 @@ ODA_UINC_VAR = "u_inc" ! default = "u_inc" ODA_VINC_VAR = "v_inc" ! default = "v_inc" ! The name of the meridional vel. inc. variable in ! ODA_INCUPD_UV_FILE. -ODA_INCUPD_NHOURS = @[MOM_IAU_HRS] ! default=3.0 +ODA_INCUPD_NHOURS = @[ODA_INCUPD_NHOURS] ! default=3.0 ! Number of hours for full update (0=direct insertion). ! === module MOM_domains === @@ -430,7 +430,7 @@ VISC_RES_FN_POWER = 2 ! [nondim] default = 100 ! used, although even integers are more efficient to calculate. Setting this ! greater than 100 results in a step-function being used. This function affects ! lateral viscosity, Kh, and not KhTh. -INTERNAL_WAVE_SPEED_BETTER_EST = False ! [Boolean] default = True +INTERNAL_WAVE_SPEED_BETTER_EST = False ! [Boolean] default = True ! If true, use a more robust estimate of the first mode wave speed as the ! starting point for iterations. @@ -829,6 +829,28 @@ ENERGYSAVEDAYS = 0.25 ! [days] default = 1.0 ! other globally summed diagnostics. ! === module ocean_model_init === +ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False + ! If true, oda incremental updates will be applied + ! everywhere in the domain. +ODA_INCUPD_FILE = "inc.nc" ! The name of the file with the T,S,h increments. + +ODA_TEMPINC_VAR = "Temp" ! default = "ptemp_inc" + ! The name of the potential temperature inc. variable in + ! ODA_INCUPD_FILE. +ODA_SALTINC_VAR = "Salt" ! default = "sal_inc" + ! The name of the salinity inc. variable in + ! ODA_INCUPD_FILE. +ODA_THK_VAR = "h" ! default = "h" + ! The name of the int. depth inc. variable in + ! ODA_INCUPD_FILE. +ODA_INCUPD_UV = false ! +!ODA_UINC_VAR = "u" ! default = "u_inc" + ! The name of the zonal vel. inc. variable in + ! ODA_INCUPD_UV_FILE. +!ODA_VINC_VAR = "v" ! default = "v_inc" + ! The name of the meridional vel. inc. variable in + ! ODA_INCUPD_UV_FILE. +ODA_INCUPD_NHOURS = @[ODA_INCUPD_NHOURS] ! default=3.0 ! === module MOM_surface_forcing === OCEAN_SURFACE_STAGGER = "A" ! default = "C" diff --git a/parm/mom6/MOM_input_template_500 b/parm/mom6/MOM_input_template_500 index 2cae7e88a96..3edce1fd990 100644 --- a/parm/mom6/MOM_input_template_500 +++ b/parm/mom6/MOM_input_template_500 @@ -492,7 +492,9 @@ MAXTRUNC = 1000 ! [truncations save_interval-1] default = 0 ! to stop if there is any truncation of velocities. ! === module ocean_model_init === -ODA_INCUPD = @[MOM_IAU] ! [Boolean] default = False + +! === module MOM_oda_incupd === +ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False ! If true, oda incremental updates will be applied ! everywhere in the domain. ODA_INCUPD_FILE = "inc.nc" ! The name of the file with the T,S,h increments. @@ -513,7 +515,7 @@ ODA_INCUPD_UV = false ! !ODA_VINC_VAR = "v" ! default = "v_inc" ! The name of the meridional vel. inc. variable in ! ODA_INCUPD_UV_FILE. -ODA_INCUPD_NHOURS = @[MOM_IAU_HRS] ! default=3.0 +ODA_INCUPD_NHOURS = @[ODA_INCUPD_NHOURS] ! default=3.0 ! === module MOM_surface_forcing === OCEAN_SURFACE_STAGGER = "A" ! default = "C" diff --git a/ush/forecast_postdet.sh b/ush/forecast_postdet.sh index 23cc1348d0d..99edbe6a47b 100755 --- a/ush/forecast_postdet.sh +++ b/ush/forecast_postdet.sh @@ -776,7 +776,7 @@ MOM6_postdet() { exit 111 fi $NLN "${ROTDIR}/${CDUMP}.${PDY}/${cyc}/ocean/${CDUMP}.t${cyc}z.ocninc.nc" "${DATA}/INPUT/inc.nc" - export MOM_IAU="true" + export ODA_INCUPD="true" fi # Copy MOM6 fixed files diff --git a/ush/parsing_namelists_MOM6.sh b/ush/parsing_namelists_MOM6.sh index 0a38c91a657..f81c3086820 100755 --- a/ush/parsing_namelists_MOM6.sh +++ b/ush/parsing_namelists_MOM6.sh @@ -15,8 +15,8 @@ MOM6_ALLOW_LANDMASK_CHANGES=${MOM6_ALLOW_LANDMASK_CHANGES:-'False'} DO_OCN_SPPT=${DO_OCN_SPPT:-'False'} PERT_EPBL=${PERT_EPBL:-'False'} -MOM_IAU=${MOM_IAU:-"false"} -MOM_IAU_HRS=${MOM_IAU_HRS:-'3.0'} +ODA_INCUPD=${ODA_INCUPD:-"false"} +ODA_INCUPD_NHOURS=${ODA_INCUPD_NHOURS:-'3.0'} if [ $cplwav = ".true." ] ; then MOM6_USE_WAVES='True' @@ -134,8 +134,8 @@ sed -e "s/@\[DT_THERM_MOM6\]/$DT_THERM_MOM6/g" \ -e "s/@\[CHLCLIM\]/$CHLCLIM/g" \ -e "s/@\[DO_OCN_SPPT\]/$OCN_SPPT/g" \ -e "s/@\[PERT_EPBL\]/$PERT_EPBL/g" \ - -e "s/@\[MOM_IAU_HRS\]/$MOM_IAU_HRS/g" \ - -e "s/@\[MOM_IAU\]/$MOM_IAU/g" $DATA/INPUT/MOM_input_template_$OCNRES > $DATA/INPUT/MOM_input + -e "s/@\[ODA_INCUPD_NHOURS\]/$ODA_INCUPD_NHOURS/g" \ + -e "s/@\[ODA_INCUPD\]/$ODA_INCUPD/g" $DATA/INPUT/MOM_input_template_$OCNRES > $DATA/INPUT/MOM_input rm $DATA/INPUT/MOM_input_template_$OCNRES #data table for runoff: From 46b1e7e939dd996c78bfe0e79af6bf18a5f8003e Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Tue, 14 Feb 2023 07:56:53 -0500 Subject: [PATCH 05/10] Update parm/mom6/MOM_input_template_025 Co-authored-by: Rahul Mahajan --- parm/mom6/MOM_input_template_025 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parm/mom6/MOM_input_template_025 b/parm/mom6/MOM_input_template_025 index 7ef27e21fec..202cc3ebb7a 100644 --- a/parm/mom6/MOM_input_template_025 +++ b/parm/mom6/MOM_input_template_025 @@ -837,7 +837,7 @@ ENERGYSAVEDAYS = 1.00 ! [days] default = 1.0 ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False ! If true, oda incremental updates will be applied ! everywhere in the domain. -ODA_INCUPD_FILE = "inc.nc" ! The name of the file with the T,S,h increments. +ODA_INCUPD_FILE = "mom6_increment.nc" ! The name of the file with the T,S,h increments. ODA_TEMPINC_VAR = "Temp" ! default = "ptemp_inc" ! The name of the potential temperature inc. variable in From b04954b09d6bb17a59ae92fd5a8d55c884e60959 Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Tue, 14 Feb 2023 07:57:06 -0500 Subject: [PATCH 06/10] Update parm/mom6/MOM_input_template_050 Co-authored-by: Rahul Mahajan --- parm/mom6/MOM_input_template_050 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parm/mom6/MOM_input_template_050 b/parm/mom6/MOM_input_template_050 index 62a7e1c6d4c..cddd1f64a68 100644 --- a/parm/mom6/MOM_input_template_050 +++ b/parm/mom6/MOM_input_template_050 @@ -864,7 +864,7 @@ RESTART_CHECKSUMS_REQUIRED = False ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False ! If true, oda incremental updates will be applied ! everywhere in the domain. -ODA_INCUPD_FILE = "inc.nc" ! The name of the file with the T,S,h increments. +ODA_INCUPD_FILE = "mom6_increment.nc" ! The name of the file with the T,S,h increments. ODA_TEMPINC_VAR = "Temp" ! default = "ptemp_inc" ! The name of the potential temperature inc. variable in From 55df592cca7bcc052140252d71367e3b3e0475ae Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Tue, 14 Feb 2023 07:57:18 -0500 Subject: [PATCH 07/10] Update parm/mom6/MOM_input_template_100 Co-authored-by: Rahul Mahajan --- parm/mom6/MOM_input_template_100 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parm/mom6/MOM_input_template_100 b/parm/mom6/MOM_input_template_100 index e138f76818d..ba9ab02a0eb 100644 --- a/parm/mom6/MOM_input_template_100 +++ b/parm/mom6/MOM_input_template_100 @@ -832,7 +832,7 @@ ENERGYSAVEDAYS = 0.25 ! [days] default = 1.0 ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False ! If true, oda incremental updates will be applied ! everywhere in the domain. -ODA_INCUPD_FILE = "inc.nc" ! The name of the file with the T,S,h increments. +ODA_INCUPD_FILE = "mom6_increment.nc" ! The name of the file with the T,S,h increments. ODA_TEMPINC_VAR = "Temp" ! default = "ptemp_inc" ! The name of the potential temperature inc. variable in From acbeb76367f1c30c5a791389b4e8a763051506d9 Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Tue, 14 Feb 2023 07:57:29 -0500 Subject: [PATCH 08/10] Update parm/mom6/MOM_input_template_500 Co-authored-by: Rahul Mahajan --- parm/mom6/MOM_input_template_500 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parm/mom6/MOM_input_template_500 b/parm/mom6/MOM_input_template_500 index 3edce1fd990..8b739a7709b 100644 --- a/parm/mom6/MOM_input_template_500 +++ b/parm/mom6/MOM_input_template_500 @@ -497,7 +497,7 @@ MAXTRUNC = 1000 ! [truncations save_interval-1] default = 0 ODA_INCUPD = @[ODA_INCUPD] ! [Boolean] default = False ! If true, oda incremental updates will be applied ! everywhere in the domain. -ODA_INCUPD_FILE = "inc.nc" ! The name of the file with the T,S,h increments. +ODA_INCUPD_FILE = "mom6_increment.nc" ! The name of the file with the T,S,h increments. ODA_TEMPINC_VAR = "Temp" ! default = "ptemp_inc" ! The name of the potential temperature inc. variable in From 6be7442520457e5eeb4de7e5c7df2cc6c7bceff8 Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Tue, 14 Feb 2023 07:57:49 -0500 Subject: [PATCH 09/10] Update ush/forecast_postdet.sh Co-authored-by: Rahul Mahajan --- ush/forecast_postdet.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ush/forecast_postdet.sh b/ush/forecast_postdet.sh index 99edbe6a47b..6c21842db8a 100755 --- a/ush/forecast_postdet.sh +++ b/ush/forecast_postdet.sh @@ -775,7 +775,7 @@ MOM6_postdet() { echo "FATAL ERROR: Ocean increment not found, ABORT!" exit 111 fi - $NLN "${ROTDIR}/${CDUMP}.${PDY}/${cyc}/ocean/${CDUMP}.t${cyc}z.ocninc.nc" "${DATA}/INPUT/inc.nc" + $NLN "${ROTDIR}/${CDUMP}.${PDY}/${cyc}/ocean/${CDUMP}.t${cyc}z.ocninc.nc" "${DATA}/INPUT/mom6_increment.nc" export ODA_INCUPD="true" fi From b8963eef9c1debbc6db812d5fd0e2978ab77e40a Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Tue, 14 Feb 2023 18:29:57 -0500 Subject: [PATCH 10/10] typos + remove export --- parm/mom6/MOM_input_template_025 | 2 +- parm/mom6/MOM_input_template_050 | 2 +- parm/mom6/MOM_input_template_100 | 2 +- ush/load_ufsda_modules.sh | 1 - 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/parm/mom6/MOM_input_template_025 b/parm/mom6/MOM_input_template_025 index 202cc3ebb7a..9e4d1caf451 100644 --- a/parm/mom6/MOM_input_template_025 +++ b/parm/mom6/MOM_input_template_025 @@ -892,7 +892,7 @@ LIQUID_RUNOFF_FROM_DATA = @[MOM6_RIVER_RUNOFF] ! [Boolean] default = False ! the data_table using the component name 'OCN'. ! === module ocean_stochastics === DO_SPPT = @[DO_OCN_SPPT] ! [Boolean] default = False - ! If true perturb the diabatic tendencies in MOM_diabadic_driver + ! If true perturb the diabatic tendencies in MOM_diabatic_driver PERT_EPBL = @[PERT_EPBL] ! [Boolean] default = False ! If true perturb the KE dissipation and destruction in MOM_energetic_PBL ! === module MOM_restart === diff --git a/parm/mom6/MOM_input_template_050 b/parm/mom6/MOM_input_template_050 index cddd1f64a68..cebc166a91b 100644 --- a/parm/mom6/MOM_input_template_050 +++ b/parm/mom6/MOM_input_template_050 @@ -937,7 +937,7 @@ LIQUID_RUNOFF_FROM_DATA = @[MOM6_RIVER_RUNOFF] ! [Boolean] default = False ! the data_table using the component name 'OCN'. ! === module ocean_stochastics === DO_SPPT = @[DO_OCN_SPPT] ! [Boolean] default = False - ! If true perturb the diabatic tendencies in MOM_diabadic_driver + ! If true perturb the diabatic tendencies in MOM_diabatic_driver PERT_EPBL = @[PERT_EPBL] ! [Boolean] default = False ! If true perturb the KE dissipation and destruction in MOM_energetic_PBL ! === module MOM_restart === diff --git a/parm/mom6/MOM_input_template_100 b/parm/mom6/MOM_input_template_100 index ba9ab02a0eb..4ac54302e1f 100644 --- a/parm/mom6/MOM_input_template_100 +++ b/parm/mom6/MOM_input_template_100 @@ -878,7 +878,7 @@ FIX_USTAR_GUSTLESS_BUG = False ! [Boolean] default = True ! velocity ! === module ocean_stochastics === DO_SPPT = @[DO_OCN_SPPT] ! [Boolean] default = False - ! If true perturb the diabatic tendencies in MOM_diabadic_driver + ! If true perturb the diabatic tendencies in MOM_diabatic_driver PERT_EPBL = @[PERT_EPBL] ! [Boolean] default = False ! If true perturb the KE dissipation and destruction in MOM_energetic_PBL diff --git a/ush/load_ufsda_modules.sh b/ush/load_ufsda_modules.sh index e4e033651fb..6f5b08e3f97 100755 --- a/ush/load_ufsda_modules.sh +++ b/ush/load_ufsda_modules.sh @@ -1,7 +1,6 @@ #! /usr/bin/env bash ############################################################### -export DEBUG_WORKFLOW="${DEBUG_WORKFLOW:-NO}" if [[ "${DEBUG_WORKFLOW}" == "NO" ]]; then echo "Loading modules quietly..." set +x