From 03b34eef8f208f0fdd1ee8fbb4c5393bf8306e4b Mon Sep 17 00:00:00 2001 From: "Walter.Kolczynski" Date: Tue, 6 Sep 2022 04:15:36 +0000 Subject: [PATCH] Correct shell linter config Per comment from the developer on PR #1008 after it was merged, the `shell-scripts` option for the shell linter does not do the globbing we expected. However, the linter action also only annotates when syntax issues are *added*. It will not flag files with existing errors, even if they are otherwise changed (at least, this is my understanding). So, immediately processing all shell files shouldn't be an issue (fingers crossed). Refs: #397 --- .github/workflows/linters.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/linters.yaml b/.github/workflows/linters.yaml index 61b8a23229f..e0ac903f183 100644 --- a/.github/workflows/linters.yaml +++ b/.github/workflows/linters.yaml @@ -28,4 +28,3 @@ jobs: uses: redhat-plumbers-in-action/differential-shellcheck@latest with: token: ${{ secrets.GITHUB_TOKEN }} - shell-scripts: ush/preamble.sh