Bring in NCO Intel DEBUG build changes.

[BrianCurtis-NOAA]

Description

Bring in NCO DEBUG flag change for ops

NCO requires that all DEBUG builds have at least the following: -check all -ftrapuv

What bug does it fix, or what feature does it add? Meets implementation standards for ops debug builds
Is a change of answers expected from this PR? No

Issue(s) addressed

Testing

How were these changes tested? UFSWM Regression Testing Suite
What compilers / HPCs was it tested with? Gaea C6, Intel
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? Yes
On what platform? GaeaC6
Will the code updates change regression test baseline? No

Dependencies

• waiting on Bring in -check all and -ftrapuv to DEBUG intell builds NOAA-GFDL/GFDL_atmos_cubed_sphere#386
• waiting on Bring in -check all and -ftrapuv to DEBUG intelllvm builds UPP#1256

[BrianCurtis-NOAA]

Could a CM look over and give preliminary approval for the code changes. This is a requirement for UFSWM.

[BrianCurtis-NOAA]

@DusanJovic-NOAA not sure who your # 2 reviewer will be, please assign

[BrianCurtis-NOAA]

@BrianCurtis-NOAA I think your atmos_cubed_sphere hash needs an update to bd2b399?

https://github.com/BrianCurtis-NOAA/ufsatm/tree/nco_debug_changes/fv3 it is?

[gspetro-NOAA]

@BrianCurtis-NOAA I think your atmos_cubed_sphere hash needs an update to bd2b399?

https://github.com/BrianCurtis-NOAA/ufsatm/tree/nco_debug_changes/fv3 it is?

No, I confused myself, but it looks fine (which is why I deleted the comment), but I'm perplexed because the WM repo_check is failing for reasons related to atmos_cubed_sphere. I suppose it's just because this hasn't been merged. Sorry for the false alarm.

[BrianCurtis-NOAA]

@BrianCurtis-NOAA I think your atmos_cubed_sphere hash needs an update to bd2b399?

https://github.com/BrianCurtis-NOAA/ufsatm/tree/nco_debug_changes/fv3 it is?

No, I confused myself, but it looks fine (which is why I deleted the comment), but I'm perplexed because the WM repo_check is failing for reasons related to atmos_cubed_sphere. I suppose it's just because this hasn't been merged. Sorry for the false alarm.

No problem, always appreciated!

[gspetro-NOAA]

Could a CM please merge this PR?