MYNNsfc uniform real kind#611
Merged
jkbk2004 merged 10 commits intoJan 6, 2023
Merged
Conversation
added 4 commits
December 2, 2022 09:08
Collaborator
|
@dustinswales Reminder to point to NCAR/ccpp-framework#456 |
Collaborator
Author
@grantfirl Thanks for the reminder. Done. |
added 4 commits
December 16, 2022 10:49
ChunxiZhang-NOAA
approved these changes
Jan 6, 2023
Contributor
Collaborator
|
@dustinswales can you update ccpp-framework and ccpp submodule pointers and revert gitmodules branchs? |
BrianCurtis-NOAA
approved these changes
Jan 6, 2023
DusanJovic-NOAA
approved these changes
Jan 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change modifies REAL-type variables and specific REAL-type constants so that they uniformly utilize the kind=kind_phys definition for REAL types found in the CCPP-physics machine.F file. This reduces casting and recasting of REALs between types of differing precision. Additional changes include changing occurances of ALOG to LOG to support more than single precision REALs as needed when kind=kind_phys is defined in that manner.
Opened on behalf of @timsliwinski-noaa
Testing
No changes to baselines for UFS regression tests with Intel on Cheyenne.