Add new PBL diagnostic variables dkt and dku#269
Merged
junwang-noaa merged 10 commits intoApr 21, 2021
Conversation
This was referenced Apr 2, 2021
Contributors: Andrew Hazelton, Chunxi Zhang, Bin Liu
BinLiu-NOAA
changed the title
…iables in GFS_typedefs.meta. Contributors: Chunxi Zhang and Bin Liu
…dard_names for dkt/dku back to atmosphere_heat/momentum_diffusivity. *Update submodule ccpp/physics.
climbfuji
approved these changes
Apr 20, 2021
…GFS_typedefs.F90.
BinLiu-NOAA
force-pushed
the
feature/dkudiagnostic
branch
from
68ad001 to
2c81cfd
Compare
Collaborator
|
Please bring this branch up-to-date with NOAA-EMC:develop |
junwang-noaa
approved these changes
Apr 21, 2021
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
I hope the dkt/dku long name can be consistent with the output long name in ExtDiag(idx)%desc, but it can be done later.
Collaborator
|
Bin, since all the RTs are is done, I suggest not to make further changes
this time, we can make the name change in next FV3 PR.
…On Wednesday, April 21, 2021, Bin Liu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ccpp/data/GFS_typedefs.F90
<#269 (comment)>:
> @@ -5800,6 +5804,10 @@ subroutine diag_create (Diag, IM, Model)
!--- 3D diagnostics for Thompson MP / GFDL MP
allocate (Diag%refl_10cm(IM,Model%levs))
+ !--- New PBL Diagnostics
+ allocate (Diag%dkt(IM,Model%levs))
Hi @climbfuji <https://github.com/climbfuji>, @junwang-noaa
<https://github.com/junwang-noaa>, @BrianCurtis-NOAA
<https://github.com/BrianCurtis-NOAA>, Following the above discussions, I
made the following changes at the FV3atm level:
- Define and allocate dkt and dku (atmosphere heat/momentum
diffusivity in GFS_typedefs.F90/meta with km levels.
- Unify the long name and Diag%desc for dkt and dku (address Jun's
another comment)
See more details can be seen from this link
<https://github.com/hafs-community/fv3atm/compare/feature/dkudiagnostic...hafs-community:feature/dktdku?expand=1>
.
@ChunxiZhang-NOAA <https://github.com/ChunxiZhang-NOAA> conducted a test
with his previous failed debug test when outputting dkt and dku as diag
variables, which can now go through successfully.
If you all agree, I can commit these changes into this Pull Request.
Please let us know how you would like to proceed. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#269 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TNG2KKSTRQESJJUZXTTJ3I35ANCNFSM42IZZQBA>
.
|
Collaborator
Author
@junwang-noaa, This sounds good and reasonable to me. Thanks! |
Collaborator
|
ccpp/physics has merged the changes. Please revert .gitmodules and update the pointer to NCAR:master for ccpp/physics. |
climbfuji
approved these changes
Apr 21, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
ccpp-physics hash is correct. I created an issue to change the vertical dimension for the two arrays in ccpp-physics: NCAR/ccpp-physics#639
Collaborator
|
Bin, do we need to wait for Chunxi and Andrew to review the code or are we
ready to commit?
…On Wed, Apr 21, 2021 at 11:12 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** approved this pull request.
ccpp-physics hash is correct. I created an issue to change the vertical
dimension for the two arrays in ccpp-physics: NCAR/ccpp-physics#639
<NCAR/ccpp-physics#639>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#269 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TNRDV4DILE65PDPV4DTJ3TN3ANCNFSM42IZZQBA>
.
|
Collaborator
Author
|
@junwang-noaa No, we do not need to wait for them. They are contributors for these changes. So, the PR is ready to go in this sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new PBL diagnostic variables dkt and dku (atmosphere heat and momentum diffusivity)
Contributors: @ChunxiZhang-NOAA and @AndrewHazelton, @BinLiu-NOAA
This PR addresses ccpp-physics issue #606 .
Related PRs:
NCAR/ccpp-physics/pull/607
ufs-community/ufs-weather-model/pull/505