Clean up w3profsmd pdlib

[MathieuDutSik]

Pull Request Summary

Some cleaning of the w3profsmd_pdlib file that should not change any functionality.

Description

Some unused code has been cleaned. Plus a lot of debugging stuff that is not relevant is cleaned up.

Issue(s) addressed

There has been several complaints about code quality and this PR certainly makes it better.

Commit Message

Clean up w3profsmd pdlib

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? These changes will be tested via the matrix
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes, this is removal of no longer needed. debug statements.
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? Orion, intel
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  There should be no changes.
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
  (will be added below).

[JessicaMeixner-NOAA]

@MathieuDutSik Can you merge the NOAA-EMC/WW3 develop branch into your branch here?

[JessicaMeixner-NOAA]

Should we go ahead and clean up the "end of W3SPR4" here as well?

[JessicaMeixner-NOAA]

Actually your additions of the subroutine names in the "end" lines have pointed out that we have a lot of "End of XXXX" comments that do not match the subroutines in this file. Are you interested in cleaning this up now, or leaving this for later?

[JessicaMeixner-NOAA]

Should these "End of W3XYPFSN" comments get cleaned up too? There are multiple.

[JessicaMeixner-NOAA]

I'll start running the regression tests.

[JessicaMeixner-NOAA]

Actually your additions of the subroutine names in the "end" lines have pointed out that we have a lot of "End of XXXX" comments that do not match the subroutines in this file. Are you interested in cleaning this up now, or leaving this for later?

[JessicaMeixner-NOAA]

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

The output of diffs:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
ww3_ta1/./work_UPD0F_U                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.14/./work_OASACM6                     (1 files differ)
ww3_tp2.14/./work_OASACM                     (1 files differ)
ww3_tp2.14/./work_OASOCM                     (1 files differ)
ww3_tp2.14/./work_OASACM4                     (1 files differ)
ww3_tp2.14/./work_OASACM5                     (1 files differ)
ww3_tp2.14/./work_OASICM                     (1 files differ)
ww3_tp2.14/./work_OASACM2                     (1 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.17/./work_mb                     (1 files differ)
ww3_tp2.17/./work_b                     (1 files differ)
ww3_tp2.17/./work_mc                     (1 files differ)
ww3_tp2.17/./work_a                     (1 files differ)
ww3_tp2.17/./work_c                     (1 files differ)
ww3_tp2.17/./work_ma                     (1 files differ)
ww3_tp2.17/./work_mc1                     (1 files differ)
ww3_tp2.17/./work_ma1                     (1 files differ)

These are expected known not b4b + known mod_def for unstructured not reporducing + tp2.14 tests having some diffs that I've occasionally seen with orion/intel:

***
/work2/noaa/marine/jmeixner/PR_WW3/pr792/regtests/output/ww3_tp2.14/work_OASACM6/debug.root.01_diff.txt
***
10c10
<  oasis_init_comp mpi_comm_local =  -2080374782
---
>  oasis_init_comp mpi_comm_local =  -2080374780
18c18
<  localcomm : -2080374782
---
>  localcomm : -2080374780

[JessicaMeixner-NOAA]

Thanks @MathieuDutSik for the continued updates of debug print statements!