Skip to content

Fix bugzilla 1370 and 1371 for WAFS blending job #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YaliMao-NOAA merged 1 commit into from
Sep 30, 2024
Merged

Fix bugzilla 1370 and 1371 for WAFS blending job #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions dev/driver/run_JWAFS_GRIB2_0P25_BLENDING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,24 @@ export KEEPDATA=YES
############################################
# Define DATA PCOM, COMOUT and COMIN
############################################

# For COMOUT
export COMROOT=/lfs/h2/emc/ptmp/$USER/wafs_dwn/$envir/com

export COMPATH=$COMROOT/wafs
# For COMIN
# export COMPATH=$COMROOT/wafs
export COMPATH=/lfs/h2/emc/ptmp/yali.mao/wafsxPDY/com/wafs

export DATA=/lfs/h2/emc/ptmp/$USER/working_wafs/blending.$jobid

############################################
# run the job
#############################################
# Set up mailing list
if [[ "${envir}" != "prod" ]]; then
MAILTO="yali.mao@noaa.gov"
fi
Comment on lines +99 to +101

@aerorahul aerorahul Oct 1, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't hard-wire user emails/

export MAILTO=${MAILTO:-"nco.spa@noaa.gov,ncep.sos@noaa.gov,nco.sos@noaa.gov,nco.hpc.dataflow@noaa.gov"}

sh $HOMEwafs/jobs/JWAFS_GRIB2_0P25_BLENDING

exit
6 changes: 6 additions & 0 deletions ecf/scripts/grib2/0p25/blending/jwafs_grib2_0p25_blending_master.ecf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ set -x
############################################################
# CALL executable job script here
############################################################
# Set up mailing list
if [[ "${envir}" != "prod" ]]; then
MAILTO="nco.spa@noaa.gov"
fi
Comment on lines +44 to +46

@aerorahul aerorahul Oct 1, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this block supposed to achieve.
Does nco.spa need to be alerted for a parallel, or a test?

export MAILTO=${MAILTO:-"nco.spa@noaa.gov,ncep.sos@noaa.gov,nco.sos@noaa.gov,nco.hpc.dataflow@noaa.gov"}

${HOMEwafs}/jobs/JWAFS_GRIB2_0P25_BLENDING
if [ $? -ne 0 ]; then
ecflow_client --msg="***JOB ${ECF_NAME} ERROR RUNNING J-SCRIPT ***"
Expand Down
9 changes: 1 addition & 8 deletions scripts/exwafs_grib2_0p25_blending.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,6 @@ fi
##########################
# Data dissemination
##########################

# Set up mailing list
if [[ "${envir}" != "prod" ]]; then
maillist="nco.spa@noaa.gov"
fi
maillist=${maillist:-"nco.spa@noaa.gov,ncep.sos@noaa.gov,nco.hpc.dataflow@noaa.gov"}

if [[ "${SEND_UNBLENDED_US_WAFS}" == "YES" ]]; then

# checking any US WAFS product was sent due to No UK WAFS GRIB2 file or WAFS blending program
Expand All @@ -131,7 +124,7 @@ if [[ "${SEND_UNBLENDED_US_WAFS}" == "YES" ]]; then
cat missing_uk_files >>mailmsg
echo "Skipping t${cyc}z f${fhr}..." >>mailmsg
cat mailmsg >"${COMOUT}/${RUN}.t${cyc}z.f${fhr}.wafs_blend_0p25_usonly.emailbody"
cat "${COMOUT}/${RUN}.t${cyc}z.f${fhr}.wafs_blend_0p25_usonly.emailbody" | mail.py -s "${subject}" "${maillist}" -v
cat "${COMOUT}/${RUN}.t${cyc}z.f${fhr}.wafs_blend_0p25_usonly.emailbody" | mail.py -s "${subject}" "${MAILTO}" -v

# Distribute US WAFS unblend Data to NCEP FTP Server (WOC) and TOC
echo "altering the unblended US WAFS products:"
Expand Down