From b0681a660c1f2ba1fda39b3897973759235454b6 Mon Sep 17 00:00:00 2001
From: YaliMao-NOAA <Yali.Mao@noaa.gov>
Date: Wed, 10 Apr 2024 20:33:32 +0000
Subject: [PATCH] For RRFS, change the mnemonics of column max of EDPARM from
 EDPARM on 0m level to MXEDPRM of the entire atmosphere. For this purpose,
 MXEDPRM is added to both post_avblflds.xml and control file fv3lam_rrfs.xml

---
 parm/fv3lam_rrfs.xml                |  7 ++++-
 parm/post_avblflds.xml              |  8 ++++++
 parm/postxconfig-NT-fv3lam_rrfs.txt | 43 +++++++++++++++++++++++++++--
 sorc/ncep_post.fd/MISCLN.f          | 16 +++++------
 4 files changed, 61 insertions(+), 13 deletions(-)

diff --git a/parm/fv3lam_rrfs.xml b/parm/fv3lam_rrfs.xml
index ae8e84c93..cac4b10f2 100755
--- a/parm/fv3lam_rrfs.xml
+++ b/parm/fv3lam_rrfs.xml
@@ -3484,9 +3484,14 @@
     <field_datatype>fltng_pnt</field_datatype>
     <comprs_type>lossless</comprs_type>
 
+      <param>
+        <shortname>MXEDPRM_ON_ENTIRE_ATMOS</shortname>
+        <scale>3.0</scale>
+      </param>
+
       <param>
         <shortname>EDPARM_GTG_ON_SPEC_ALT_ABOVE_MEAN_SEA_LVL</shortname>
-        <level>30. 304. 609. 914. 1219. 1524. 1828. 2133. 2438. 2743. 3048. 3352. 3657. 3962. 4267. 4572. 4876. 5181. 5486. 5791. 6096. 6400. 6705. 7010. 7315. 7620. 7924. 8229. 8534. 8839. 9144. 9448. 9753. 10058. 10363. 10668. 10972. 11277. 11582. 11887. 12192. 12496. 12801. 13106. 13411. 13716. 14020. 14325. 14630. 14935. 15240. 0.</level>
+        <level>30. 304. 609. 914. 1219. 1524. 1828. 2133. 2438. 2743. 3048. 3352. 3657. 3962. 4267. 4572. 4876. 5181. 5486. 5791. 6096. 6400. 6705. 7010. 7315. 7620. 7924. 8229. 8534. 8839. 9144. 9448. 9753. 10058. 10363. 10668. 10972. 11277. 11582. 11887. 12192. 12496. 12801. 13106. 13411. 13716. 14020. 14325. 14630. 14935. 15240.</level>
         <scale>3.0</scale>
       </param>
 
diff --git a/parm/post_avblflds.xml b/parm/post_avblflds.xml
index 79f8c7da9..a49f8f110 100755
--- a/parm/post_avblflds.xml
+++ b/parm/post_avblflds.xml
@@ -4145,6 +4145,14 @@
        <scale>6.0</scale>
     </param>
 
+    <param>
+       <post_avblfldidx>476</post_avblfldidx>
+       <shortname>MXEDPRM_ON_ENTIRE_ATMOS</shortname>
+       <pname>MXEDPRM</pname>
+       <fixed_sfc1_type>entire_atmos</fixed_sfc1_type>
+       <scale>3.0</scale>
+    </param>
+
 <!-- 477 EDR on FD_HEIGHT_LVL (for regional model)-->
     <param>
        <post_avblfldidx>477</post_avblfldidx>
diff --git a/parm/postxconfig-NT-fv3lam_rrfs.txt b/parm/postxconfig-NT-fv3lam_rrfs.txt
index 303df2122..5dc0d8f3f 100644
--- a/parm/postxconfig-NT-fv3lam_rrfs.txt
+++ b/parm/postxconfig-NT-fv3lam_rrfs.txt
@@ -1,5 +1,5 @@
 4
-4
+5
 3
 235
 282
@@ -19307,6 +19307,43 @@ complex_packing_spatial_diff
 2nd_ord_sptdiff
 fltng_pnt
 lossless
+476
+MXEDPRM_ON_ENTIRE_ATMOS
+?
+1
+tmpl4_0
+MXEDPRM
+?
+?
+entire_atmos
+0
+?
+0
+?
+?
+0
+?
+0
+?
+?
+?
+0
+0.0
+0
+0.0
+?
+0
+0.0
+0
+0.0
+1
+3.0
+0
+0
+0
+?
+?
+?
 467
 EDPARM_GTG_ON_SPEC_ALT_ABOVE_MEAN_SEA_LVL
 ?
@@ -19318,8 +19355,8 @@ EDPARM
 spec_alt_above_mean_sea_lvl
 0
 ?
-52
-30. 304. 609. 914. 1219. 1524. 1828. 2133. 2438. 2743. 3048. 3352. 3657. 3962. 4267. 4572. 4876. 5181. 5486. 5791. 6096. 6400. 6705. 7010. 7315. 7620. 7924. 8229. 8534. 8839. 9144. 9448. 9753. 10058. 10363. 10668. 10972. 11277. 11582. 11887. 12192. 12496. 12801. 13106. 13411. 13716. 14020. 14325. 14630. 14935. 15240. 0.
+51
+30. 304. 609. 914. 1219. 1524. 1828. 2133. 2438. 2743. 3048. 3352. 3657. 3962. 4267. 4572. 4876. 5181. 5486. 5791. 6096. 6400. 6705. 7010. 7315. 7620. 7924. 8229. 8534. 8839. 9144. 9448. 9753. 10058. 10363. 10668. 10972. 11277. 11582. 11887. 12192. 12496. 12801. 13106. 13411. 13716. 14020. 14325. 14630. 14935. 15240.
 ?
 0
 ?
diff --git a/sorc/ncep_post.fd/MISCLN.f b/sorc/ncep_post.fd/MISCLN.f
index 1362b372d..c2bce66fb 100644
--- a/sorc/ncep_post.fd/MISCLN.f
+++ b/sorc/ncep_post.fd/MISCLN.f
@@ -57,6 +57,7 @@
 !!   23-08-24  Y Mao - Add gtg_on option for GTG interpolation
 !!   24-01-07  H LIN - Add CIT output in NCAR GTG turbulence calculation
 !!   24-01-09  Y Mao - Correct the height level of EDPARM (ID=467) on 0m to index 52 from the control file, instead of 0.
+!!   24-04-09 Y Mao - Change the mnemonics of EDPARM (ID=467) on 0m to MXEDPRM (ID=476) on the entire atmoshpere       
 !! USAGE:    CALL MISCLN
 !!   INPUT ARGUMENT LIST:
 !!
@@ -1238,9 +1239,8 @@ SUBROUTINE MISCLN
          end if
 
 
-!        FOR Regional GTG, ALL LEVLES OF DIFFERENT VARIABLES ARE THE SAME, except for EDPARM
-!        Use levels of iID=468 for interpolation
-         iID=468
+!        FOR Regional GTG, ALL LEVLES OF DIFFERENT VARIABLES ARE THE SAME
+         iID=467
          N = IAVBLFLD(IGET(iID))
          NFDCTL=size(pset%param(N)%level)
          if(allocated(ITYPEFDLVLCTL)) deallocate(ITYPEFDLVLCTL)
@@ -1280,10 +1280,9 @@ SUBROUTINE MISCLN
          DO N=1,nFDS
             iID=IDS(N)
             
-!           Regional GTG has a legend of special defination
-!           0 m holds the max value of the whole vertical column
-!           0 m is the last height in the control file            
-            if (iID == 467) then
+!     For regional GTG, output the max value of EDPARM(ID=467) in the whole vertical column
+!     to MXEDPRM(ID=476)
+            if (iID == 467 .and. iget(476) > 0) then
                EGRID1 = SPVAL
                DO IFD = 1,NFDCTL
                   DO J=JSTA,JEND
@@ -1304,8 +1303,7 @@ SUBROUTINE MISCLN
                ENDDO
                if(grib=='grib2') then
                   cfld=cfld+1
-                  fld_info(cfld)%ifld=IAVBLFLD(IGET(iID))
-                  fld_info(cfld)%lvl=NFDCTL+1
+                  fld_info(cfld)%ifld=IAVBLFLD(IGET(476)) ! MXEDPRM ID
 !$omp parallel do private(i,j,ii,jj)
                   do j=1,jend-jsta+1
                      jj = jsta+j-1