Add tref#419
Conversation
WenMeng-NOAA
added
bug
ice grid point for GFS and RRFS so that legacy models land masks won't be affected by this change.
|
@LydiaStefanova-NOAA Please let me know if you have comments/suggestion on this PR. |
|
@WenMeng-NOAA Could you please point me to a sample output file you get after these changes? |
|
@LydiaStefanova-NOAA See /scratch1/NCEPDEV/stmp2/Wen.Meng/gfs.20210216/gfs.t00z.sfluxgrbf006.grib2 for foundation temperature. Our regression test case has no land-sea mask issue. You should see land-sea mask fixing from Huiya's test case. |
|
The UPP regression tests were conducted on WCOSS-Dellm WCOSS-Cray and Hera. With this PR merged, the baseline for GFS needs to be recreated. |
|
Thanks, @WenMeng-NOAA - I can't comment on the code side of things, but checked the output and confirm that foundation temperature is present, and that the land/sea mask and ice concentrations are in agreement. Thank you very much for these fixes! |
|
@LydiaStefanova-NOAA Thanks for confirming. |
|
This PR is ready for merging. |
|
@WenMeng-NOAA thank you for running UPP regression tests and merging the code quickly. @LydiaStefanova-NOAA @JessicaMeixner-NOAA your requested changes for land masks and foundation T output are now in |
|
Thanks @WenMeng-NOAA and @HuiyaChuang-NOAA for these updates, we look forward to being able to use them in the inline post in the future. |
…A-EMC#419) * Updating fix files to output GOES-16 simulated brightness temps. * Including the new GOES-16 simulated satellite brightness temps in smaller distributed files. * Correcting the names of the new fields in testbed .txt file. Fields appear differently with different versions of wgrib2!
…uplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1; contains "fix the number of 2d fields nsfcprop2d" (NOAA-EMC#419) (NOAA-EMC#417) - Fixes a bug inGFS_diagnostics.F90 that registered several stochastic variables as diagnostic output even though th arrays are not allocated if the corresponding stochastic option is turned off - Fixes a problem that led to a "duplicate symbols" error on macOS with Intel by removing files from ccpp/CMakeLists.txt that get added automatically by CCPP - Updates the submodule pointer for ccpp-physics for the changes described in Cleanup CCPP cmake flags part 1, remove extra logic that reduces optimization for radiation_aerosols.f, update CODEOWNERS, update README.md NCAR/ccpp-physics#773 - Contains the changes in fix the number of 2d fields nsfcprop2d NOAA-EMC#419 from @HelinWei-NOAA - Updates the submodule pointer for GFDL_atmos_cubed_sphere to include latest JEDI control changes (contributed by @mark-a-potts)
4 participants
Add IO of foundation temperature as well as fix how sea ice grid point is identified as land now that future coupled GFS will use fractional ice.