swap signs on imported fields#4
Merged
BinLiu-NOAA merged 3 commits intoAug 11, 2023
Merged
Conversation
Author
|
@BinLiu-NOAA I'm not sure when this will be needed for the UFS PR, but I wanted to go ahead and put it in so you can take a look. |
39 tasks
Author
|
@BinLiu-NOAA I have a dependent PR for UFS which will require approval prior to starting testing. Thanks. |
danrosen25
approved these changes
Aug 8, 2023
danrosen25
left a comment
There was a problem hiding this comment.
I'm fine with this change. It would be nice if the standard name or the field dictionary included directional information so that it's available to the developer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within FV3atm, the sign of 4 export fields will be changed at the time they are exported from the ATM. These fields are the momentum stresses, and the sensible and latent heat fluxes. This work is associated with NOAA-EMC/CMEPS#93.
This PR will change make the signs consistently in the HYCOM cap to accommodate the new ATM exports. In testing, this change is B4B for the HAFS RTs in UFS, with the exception of the mediator restart or history files which have differences only of sign, not actual value.