Skip to content

Add PlanetiQ YAM-8 in global_convinfo_2mObs.txt#49

Closed
XuanliLi-NOAA wants to merge 3 commits into
NOAA-EMC:developfrom
XuanliLi-NOAA:add_piqyam8
Closed

Add PlanetiQ YAM-8 in global_convinfo_2mObs.txt#49
XuanliLi-NOAA wants to merge 3 commits into
NOAA-EMC:developfrom
XuanliLi-NOAA:add_piqyam8

Conversation

@XuanliLi-NOAA

@XuanliLi-NOAA XuanliLi-NOAA commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Updated global_convinfo_2mObs.txt to include PlanetiQ YAM-8 data (SAID=768) as suggested by @CoryMartin-NOAA and @ADCollard .

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as GSI-fix PR #47 but for global_convinfo_2mObs.txt.

Approve.

@RussTreadon-NOAA

Copy link
Copy Markdown
Contributor

It would be good to implement was way to not need to maintain two sets of global_convinfo files: (a) global_convinfo.txt and (b) global_convinfo_2mObs.txt. It's easy to see how future updates to one could be missed in the other.

@RussTreadon-NOAA

Copy link
Copy Markdown
Contributor

Convert this PR to draft to align with GSI PR #930.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as draft September 15, 2025 16:02
@RussTreadon-NOAA

Copy link
Copy Markdown
Contributor

@CatherineThomas-NOAA, @ClaraDraper-NOAA, @ADCollard, @CoryMartin-NOAA : What are our plans for global_convinfo.txt moving forward? We currently have global_convinfo.txt, global_convinfo_2mObs.txt, and on-the-fly construction of convinfo via create_gsi_info.sh.

This PR was opened to add gps 768 to global_convinfo_2mObs.txt. GSI-fix PR #47 previously added gps 768 to global_convinfo.txt.

Remembering to update both global_convinfo.txt and global_convinfo_2mObs.txt is problematic. One or the other will be forgotten and unintended differences will creep in. I guess the intention of the create_gsi_info.sh approach is to replace two static files with a single dynamically generated convinfo.

DA scripts in g-w currently support both the static and dynamic convinfo approaches.

if [[ "${CONVINFO}" == "generate" ]]; then
    "${USHgfs}/create_gsi_info.sh" conv "${PDY}${cyc}" "${DATA}" "${USE_2M_OBS}"
else
    ${NLN} "${CONVINFO}" convinfo
fi

When we move to JEDI atmospheric DA we can use the jcb-gdas observation_chronicle. GFS v17 maintains GSI atmospheric DA. Hence my question about our plans for maintaining the GSI info files until we fully pivot to JEDI.

@ClaraDraper-NOAA

Copy link
Copy Markdown
Contributor

I originally added the _2m option as a temporary file while we developed the 2mDA. Since the 2m obs are now being included in GFSv17, I suggest that we add the 2m obs to global_convinfo and remove the separate _2m file.

@RussTreadon-NOAA

Copy link
Copy Markdown
Contributor

I originally added the _2m option as a temporary file while we developed the 2mDA. Since the 2m obs are now being included in GFSv17, I suggest that we add the 2m obs to global_convinfo and remove the separate _2m file.

Thank you @ClaraDraper-NOAA for the explanation. I agree. global_convinfo_2mObs.txt and global_convinfo.txt can be merged into a single file, global_convinfo.txt.

@ClaraDraper-NOAA

Copy link
Copy Markdown
Contributor

Note this related problem with the 2m obs quality control when global_convinfo is dynamically generated.

@XuanliLi-NOAA XuanliLi-NOAA closed this by deleting the head repository Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants