Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTVFanart() is never used #1296

Closed
ghost opened this issue Apr 4, 2023 · 2 comments
Closed

getTVFanart() is never used #1296

ghost opened this issue Apr 4, 2023 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 4, 2023

public function getTVFanart(string $id): bool|array

This function is never used in NNTmux. Could be used to greatly improve the number of TV covers found I guess. Only works with TVDB ID's so might be used inside TVDB class. Only the getMovieFanArt function of Fanart is used right now.

Could be used inside the getPoster() function perhaps, but it would also need the TVDB ID for that, now only the VideoID is used for that function.

If used to grab posters, this is a good addition IMHO. It grabs the TV Poster with the most likes, which usually means the original English one:

$poster = collect($fanArt['tvposter'])->sortByDesc('likes')[0]['url'];
@DariusIII
Copy link
Member

Feel free to create a PR and i will gladly accept it.

@ghost
Copy link
Author

ghost commented Apr 4, 2023

Tested and working: #1298

@ghost ghost closed this as completed Apr 4, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant