From 1b9980a83300b700b1b06d8c3cbf5b4c419bc350 Mon Sep 17 00:00:00 2001 From: Shift Date: Fri, 15 Sep 2023 18:11:30 +0000 Subject: [PATCH 1/3] Bump PHPUnit dependencies --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 647b068a26..1797b8522a 100644 --- a/composer.json +++ b/composer.json @@ -129,7 +129,7 @@ "nunomaduro/collision": "^7.0", "nunomaduro/larastan": "^2.6", "php-coveralls/php-coveralls": "^2.0", - "phpunit/phpunit": "^8.0 || ^9.0 || ^10.0", + "phpunit/phpunit": "^10.0", "rector/rector": "^0.18.0" }, "suggest": { From 74639626b2153f0505b36456970044898a46ad0c Mon Sep 17 00:00:00 2001 From: Shift Date: Fri, 15 Sep 2023 18:11:30 +0000 Subject: [PATCH 2/3] Ignore PHPUnit cache folder --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 9e2d5f6330..faef3ded34 100644 --- a/.gitignore +++ b/.gitignore @@ -37,3 +37,5 @@ node_modules/ # Stores VSCode versions used for testing VSCode extensions .vscode-test + +/.phpunit.cache \ No newline at end of file From 84eab4b697bd9c00ea881511ca1bd694b9f9a59f Mon Sep 17 00:00:00 2001 From: Shift Date: Fri, 15 Sep 2023 18:11:30 +0000 Subject: [PATCH 3/3] Define test classes as `final` --- tests/Feature/BooksTest.php | 2 +- tests/Feature/SettingsTest.php | 2 +- tests/Install/InstallTest.php | 2 +- tests/Unit/ExampleTest.php | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Feature/BooksTest.php b/tests/Feature/BooksTest.php index 83ade8800c..952afe337c 100644 --- a/tests/Feature/BooksTest.php +++ b/tests/Feature/BooksTest.php @@ -4,7 +4,7 @@ use Tests\TestCase; -class BooksTest extends TestCase +final class BooksTest extends TestCase { /** * @throws \DariusIII\ItunesApi\Exceptions\InvalidProviderException diff --git a/tests/Feature/SettingsTest.php b/tests/Feature/SettingsTest.php index d3e5b6d11d..0fec271c10 100644 --- a/tests/Feature/SettingsTest.php +++ b/tests/Feature/SettingsTest.php @@ -4,7 +4,7 @@ use Tests\TestCase; -class SettingsTest extends TestCase +final class SettingsTest extends TestCase { public function testSettingValue(): void { diff --git a/tests/Install/InstallTest.php b/tests/Install/InstallTest.php index 10dce04c96..a782a9b299 100644 --- a/tests/Install/InstallTest.php +++ b/tests/Install/InstallTest.php @@ -18,7 +18,7 @@ /** * Class InstallTest. */ -class InstallTest extends \PHPUnit\Framework\TestCase +final class InstallTest extends \PHPUnit\Framework\TestCase { public function testFullInstall(): void { diff --git a/tests/Unit/ExampleTest.php b/tests/Unit/ExampleTest.php index 5773b0ceb7..fff6e3c4cf 100644 --- a/tests/Unit/ExampleTest.php +++ b/tests/Unit/ExampleTest.php @@ -4,7 +4,7 @@ use PHPUnit\Framework\TestCase; -class ExampleTest extends TestCase +final class ExampleTest extends TestCase { /** * A basic test example.