-
Notifications
You must be signed in to change notification settings - Fork 3
Use dynamic_versioning
as backend
#448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Mmm, that is dangerous: because e.g. master is at the moment definitely NOT 0.14 ... and as I was arguing in #417 with @evagroenendijk it is wrong to call master v0.15, because v0.15 might (or might not) contain even more breaking changes than now; so I think I prefer v0.0 - which should never appear in public codes any ways, but only for developers (who can deal with it) |
But in practice we have many fktables and ekos produced with 0.0.0. But I do see the point, perhaps a better solution would be to (for a developing installation) get the commit without the tag? Edit: perhaps I didn't explain myself well in the OP, |
is it possible to just have the commit?
or do we always need the full thing? in any case we will need to adjust the legacy handling (initialised in #417) - specifically, we need to adjust this logic: Line 67 in 35e1a55
and upload a new file version as explained here https://github.com/NNPDF/eko/blob/master/tests/data/assets.sh |
do you want to split this change from this PR? since I guess that change is uncontroversial (and does hopefully have no tail) |
Yes. But
How does the legacy handler deals with 0.0.0 since it can be any version? (and adding the commit won't solve that) (edit: in any case, I added the versioning because I thought it would have no downstream effects, since it does let's leave it be) |
ehm simply this Line 69 in 35e1a55
and this Line 71 in 35e1a55
is false and so no recover is applied - i.e. it assumes it is master. We only support versions after v0.13.5
|
This reverts commit c87073c.
dynamic_versioning
as backend
put dynamic_versioning as the backend so that one gets 0.14.whatever instead of 0.0.0 when using it locally, not sure whether that will mess up with something?
closes #365