From 0be3ee4d79c8f0ed9937cdc2a7fe7c709784b4a0 Mon Sep 17 00:00:00 2001 From: Julian Verdurmen <304NotModified@users.noreply.github.com> Date: Fri, 13 Oct 2017 23:38:15 +0200 Subject: [PATCH] Register NLogProvider instead of NLogFactory So config made before UseNLog is still applied and Microsoft's addConsole is also working fixes https://github.com/NLog/NLog.Web/issues/199 --- NLog.Web.AspNetCore/AspNetExtensions.cs | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/NLog.Web.AspNetCore/AspNetExtensions.cs b/NLog.Web.AspNetCore/AspNetExtensions.cs index 432d7b2c..71747b12 100644 --- a/NLog.Web.AspNetCore/AspNetExtensions.cs +++ b/NLog.Web.AspNetCore/AspNetExtensions.cs @@ -109,29 +109,30 @@ public static IWebHostBuilder UseNLog(this IWebHostBuilder builder, NLogAspNetCo builder.ConfigureServices(services => { - services.AddSingleton(serviceProvider => + //note: when registering ILoggerFactory, all non NLog stuff and stuff before this will be removed + services.AddSingleton(serviceProvider => { ServiceLocator.ServiceProvider = serviceProvider; NLogBuilder.RegisterNLogWebAspNetCore(); LogManager.Configuration?.Reload(); - return new NLogLoggerFactory(options); - + return new NLogLoggerProvider(options); }); + //note: this one is called before services.AddSingleton if (options.RegisterHttpContextAccessor) { services.TryAddSingleton(); } + }); + return builder; + } - }); - return builder; - } #endif