Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimplyQ: in the reach flow equations, replace EffectiveReachLength with the real reach length? #21

Open
LeahJB opened this issue Nov 23, 2022 · 1 comment

Comments

@LeahJB
Copy link
Collaborator

LeahJB commented Nov 23, 2022

In SimplyP v0.3 we replaced reach length with effective reach length in the reach flow equations. The intention was that the effective reach length should represent the average distance travelled by water within the reach (i.e. the full reach length for water from upstream, and about half the reach length for water entering from the sub-catchment). However, it makes the reach flow equations more stiff, and implicitly implies that the reach water depth is twice what it really is (for headwater catchments).

We need to think about reach water travel times a bit more generally, including this. Probably we should go back to just using the real reach length, and just make sure the reach lengths aren't too big (see Issue #20 ).

@LeahJB
Copy link
Collaborator Author

LeahJB commented Dec 20, 2022

Also factor out reach water transit time into its own equation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant