Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NHS Frontend v9 #254

Open
edwardhorsford opened this issue Sep 23, 2024 · 2 comments
Open

Upgrade to NHS Frontend v9 #254

edwardhorsford opened this issue Sep 23, 2024 · 2 comments

Comments

@edwardhorsford
Copy link
Contributor

NHS Frontend v9 was released last week. There are a few breaking changes in it.

We should first do fixes for #240 and then for this one.

@edwardhorsford
Copy link
Contributor Author

We should also read through v8.3 and see if any updates are needed for that.

@rowellx68
Copy link

Hi, I maintain a separate React implementation here that supports v9. It has a different API to this implementation though, but if there's an appetite for the changes I've made I would be happy to create a PR here.

Example differences

<Button
-   secondary
+   variant="secondary"
>Discard changes</Button>

-<ButtonLink href="/page/2">
+<Button as="a" href="/page/2">
  Next page
-</ButtonLink>
+</Button>

-<TextInput inputRef={inputRef} label="Some label" />
+<Input ref={inputRef} label="Some label" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants