perf(all): improve rxjs imports #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trotyl
changed the title
LinboLen
reviewed
Aug 16, 2017
| @@ -144,7 +145,7 @@ export class NzSubMenuComponent implements OnInit, OnDestroy, AfterViewInit { | |||
| } | |||
|
|
|||
| ngOnInit() { | |||
| this._$mouseSubject.debounceTime(300).subscribe((data: boolean) => { | |||
| debounceTime.call(this._$mouseSubject, 300).subscribe((data: boolean) => { | |||
There was a problem hiding this comment.
should wrap with runOutsideAngular.
runOutsideAngular means that every hooked global async func will restore.
baraly introduce rxjs without ngZone check is not recommend.
if use runOutsideAngular , the detectChange does't work, can force trigger detect change with ChangeDetectorRef injected in contructor as private changeDectorRef: ChangeDetectorRef then call this.changeDectorRef.detectChanges().
hope to help you
There was a problem hiding this comment.
That could be done in a separate request, since this is only for fixing the rxjs imports, shouldn't change any other part of the lib.
trotyl
changed the title
|
import {} from 'rxjs/Rx'请问这句代码应该添加到那里 |
|
@FunClub Nowhere if you're writing front-end. |
|
请问 NG-ZORRO怎么按需加载，以减小打包体积 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import {} from 'rxjs/Rx'will include the entire RxJS library.Fixes #50 .
Relates to #18 .