Skip to content

fix(module:spin): fix cdk change detection #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2018
Merged

fix(module:spin): fix cdk change detection #2255

merged 1 commit into from
Oct 10, 2018

Conversation

vthinkxie
Copy link
Member

close #1819

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #2255 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2255   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         485      485           
  Lines       12136    12136           
  Branches     1625     1625           
=======================================
  Hits        11635    11635           
  Misses        145      145           
  Partials      356      356
Impacted Files Coverage Δ
components/list/nz-list.component.ts 100% <ø> (ø) ⬆️
components/spin/nz-spin.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8861beb...ef1999c. Read the comment docs.

@vthinkxie vthinkxie merged commit 25671b6 into NG-ZORRO:master Oct 10, 2018
@vthinkxie vthinkxie deleted the fix-spin branch February 26, 2019 07:08
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-list给nzDataSource赋新值后不刷新,只有鼠标点击一下结果才出现
1 participant