Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix space closing select panel #2240

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 4, 2018

close #2201

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2201

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #2240 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2240   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         482      482           
  Lines       11965    11965           
  Branches     1594     1594           
=======================================
  Hits        11482    11482           
  Misses        134      134           
  Partials      349      349
Impacted Files Coverage Δ
components/select/nz-select.component.ts 96.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d123eb...c2902f0. Read the comment docs.

@wzhudev wzhudev requested a review from vthinkxie October 4, 2018 02:23
@vthinkxie vthinkxie merged commit 3d7fe39 into NG-ZORRO:master Oct 11, 2018
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this pull request Oct 15, 2018
@wzhudev wzhudev deleted the select-space branch October 25, 2018 04:17
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select: enable whitespace character when entering space key in search field
3 participants