Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:select): support open and close panel via keyboard #2038

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 24, 2018

close #1909

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1909

What is the new behavior?

User can open and close select panel when select component has focus.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Other components may lack of this feature. Maybe we should go through these in next refactor.

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #2038 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
+ Coverage   96.01%   96.03%   +0.01%     
==========================================
  Files         470      470              
  Lines       11424    11437      +13     
  Branches     1515     1519       +4     
==========================================
+ Hits        10969    10983      +14     
  Misses        131      131              
+ Partials      324      323       -1
Impacted Files Coverage Δ
components/select/nz-select.component.ts 96.75% <100%> (+0.2%) ⬆️
components/select/nz-option-container.component.ts 92.45% <0%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e1f5f...89bc29d. Read the comment docs.

@wzhudev wzhudev requested a review from hsuanxyz August 26, 2018 02:32
@vthinkxie vthinkxie self-requested a review September 7, 2018 08:41
@simplejason simplejason merged commit b2ea96a into NG-ZORRO:master Sep 7, 2018
hsuanxyz added a commit that referenced this pull request Sep 10, 2018
@wzhudev wzhudev deleted the select-trigger branch September 11, 2018 09:46
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nz-select] Allow nz-select open with spacebar when focused, like the default HTML select
3 participants