Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:list): fix loading style misplacement of spin #1767

Merged
merged 12 commits into from
Jul 2, 2018
Merged

fix(module:list): fix loading style misplacement of spin #1767

merged 12 commits into from
Jul 2, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 1, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1739

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jul 1, 2018

Codecov Report

Merging #1767 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1767      +/-   ##
==========================================
+ Coverage   96.05%   96.06%   +<.01%     
==========================================
  Files         466      466              
  Lines       11153    11153              
  Branches     1458     1458              
==========================================
+ Hits        10713    10714       +1     
+ Misses        127      126       -1     
  Partials      313      313
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️
components/table/nz-table.component.ts 95.93% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92675e4...2e15612. Read the comment docs.

@vthinkxie vthinkxie self-requested a review July 2, 2018 14:23
@vthinkxie vthinkxie merged commit 336cc08 into NG-ZORRO:master Jul 2, 2018
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants