Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:autocomplete): add autocomplete component #1093

Merged
merged 11 commits into from
Mar 15, 2018

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Mar 1, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.077% when pulling c701d29 on HsuanXyz:add-autocomplete into 48d593d on NG-ZORRO:0.7.0.

@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #1093 into 0.7.0 will decrease coverage by 0.04%.
The diff coverage is 96.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##           0.7.0    #1093      +/-   ##
=========================================
- Coverage     98%   97.95%   -0.05%     
=========================================
  Files        156      153       -3     
  Lines       5451     5772     +321     
  Branches     657      705      +48     
=========================================
+ Hits        5342     5654     +312     
- Misses         0        2       +2     
- Partials     109      116       +7
Impacted Files Coverage Δ
...uto-complete/nz-autocomplete-optgroup.component.ts 100% <100%> (ø)
components/auto-complete/index.ts 100% <100%> (ø)
components/auto-complete/nz-autocomplete.module.ts 100% <100%> (ø)
components/auto-complete/public-api.ts 100% <100%> (ø)
.../auto-complete/nz-autocomplete-option.component.ts 95.55% <95.55%> (ø)
...ponents/auto-complete/nz-autocomplete.component.ts 96.38% <96.38%> (ø)
...auto-complete/nz-autocomplete-trigger.directive.ts 96.47% <96.47%> (ø)
components/list/nz-list.component.ts 100% <0%> (ø) ⬆️
components/list/nz-list-item-meta.component.ts 100% <0%> (ø) ⬆️
components/modal/nz-modal.component.ts 96.07% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9ab91...0b864ba. Read the comment docs.

@hsuanxyz hsuanxyz changed the title wip(module:autocomplete): add autocomplete component feat(module:autocomplete): add autocomplete component Mar 15, 2018
@vthinkxie vthinkxie merged commit 1461293 into NG-ZORRO:0.7.0 Mar 15, 2018
@hsuanxyz hsuanxyz deleted the add-autocomplete branch May 2, 2018 04:00
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:autocomplete): add autocomplete component

* refactor(module:autocomplete): refactor autocomplete

* test(module:autocomplete): add test for autocomplete

* doc(module:autocomplete): update demo

* fix(module:autocomplete): fix lint

* feat(module:autocomplete): add toggling animation

* test(module:autocomplete): fix test

* fix(module:autocomplete): dynamic type for nzLabel in opt-group

* doc(module:autocomplete): update demo

* fix(module:autocomplete): active style

* test(module:autocomplete): add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants