-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfp test for e4s #152
Comments
@lindstro based on our discussion in email you have identified a few tests that we can run but unfortunately those tests are not in production install so i take it you will be contributing the binary with custom CMakeFile so we can test this. Is that correct. I will keep this issue open until we have a test, which can be submitted to our gitlab repo https://software.nersc.gov/NERSC/buildtest-nersc which is a mirror of this project |
We're exploring two options: (1) build |
If option 2 were available we would be happy to incorporate that into the E4S Testsuite as well. |
@lindstro just following up on this task i was wondering to get your advice on how you plan on testing zfp on our system. We have zfp installed in our e4s stack in several spack environments with different variants. Do you think you can help add a test in our repo whether this is a standalone test, spack test or E4S Testsuite. |
Our plan is to add to the zfp CLI an option to specify synthetic data as input, with checksums printed as output both for compressed and decompressed data. We'd then add a script that verifies that checksums are correct. Generating synthetic floating-point data portably is challenging, however, but we have made some progress toward this goal and are currently working on generating additional data that exercises various corner cases that could trip up zfp. We hope to have this capability in place for the zfp 1.1.0 release this fall, and hopefully sometime earlier on the |
@lindstro thanks for update, ill keep this issue open for time being we can try to install zfp 1.1.0 when its available in E4S and then circle back on adding test |
@lindstro we just released e4s/23.08 which comes with version 1.0.0, just to confirm this version doesn't have any test? siddiq90@login40> spack find --format "{name}@{version}%{compiler} %{variants}" zfp
[email protected]%gcc@=11.2.0 %~aligned~c~cuda~fasthash~fortran~ipo~openmp~profile~python+shared~strided~twoway+utilities bsws=64 build_system=cmake build_type=Release generator=make
[email protected]%gcc@=11.2.0 %~aligned~c~cuda~daz~fasthash~fortran~ipo~openmp~profile~python+shared~strided~tight-error~twoway+utilities bsws=64 build_system=cmake build_type=Release generator=make round=never This installation comes with several header files and cmake file in lib64 directory, i dont think we have anything we can test right? siddiq90@login40> find $(spack location -i [email protected])/include -type f
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/bitstream.inl
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/array.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/zfp/inline.h
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/zfp/system.h
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/zfp/macros.h
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/zfp/types.h
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/view2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/reference1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/pointer3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/iterator4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/store3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/memory.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/handle1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/reference3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/store1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/cache4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/handle3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/view4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/cache1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/exception.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/store4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/pointer4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/pointer1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/iterator3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/pointer2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/reference2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/iterator1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/cache.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/traits.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/handle2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/store.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/view1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/reference4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/view3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/store2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/handle4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/header.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/iterator2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/cache3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/array/cache2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/codec/genheader.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/internal/codec/zfpheader.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/array3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/array2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/array.h
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/bitstream.h
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/array1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/factory.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/constarray4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/version.h
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/index.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/array4.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/constarray1.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/constarray2.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/constarray3.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/codec/gencodec.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp/codec/zfpcodec.hpp
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/include/zfp.h
siddiq90@login40> find $(spack location -i [email protected])/lib64 -type f
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/lib64/cmake/zfp/zfp-config.cmake
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/lib64/cmake/zfp/zfp-targets-release.cmake
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/lib64/cmake/zfp/zfp-config-version.cmake
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/lib64/cmake/zfp/zfp-targets.cmake
/global/common/software/spackecp/perlmutter/e4s-23.08/92601/spack/opt/spack/linux-sles15-zen3/gcc-11.2.0/zfp-1.0.0-ymy2ft5gpn66ibxdrn6krx5pvk7bxbxq/lib64/libzfp.so.1.0.0 |
It is true that our Spack recipe currently does not install any tests. We're hoping to rectify this and have made some progress toward that goal, but this won't appear until the 1.1.0 release. Whatever zfp "test" is currently in E4S is not really a test--the script merely runs some of the zfp examples, which are intended to be educational. The Alternatively, you can build |
@lindstro
In our e4s/22.05 stack we have the following installations of zfp, one of them is a cuda build.
We have identified a test https://github.com/LLNL/zfp/blob/develop/tests/testzfp.cpp that could be used. We can put standalone tests in https://github.com/buildtesters/buildtest-nersc/tree/devel/buildspecs/apps with a named directory
zfp
.The text was updated successfully, but these errors were encountered: