From d8a5c5abcc0de2be21469f8ea8a0ab47c6d47a73 Mon Sep 17 00:00:00 2001 From: cenlinhe Date: Wed, 29 Jan 2025 13:17:23 -0700 Subject: [PATCH 1/5] bug fix for Stability function correction for momentum in SLUCM --- urban/wrf/module_sf_urban.F | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/urban/wrf/module_sf_urban.F b/urban/wrf/module_sf_urban.F index ef9764c..8168496 100644 --- a/urban/wrf/module_sf_urban.F +++ b/urban/wrf/module_sf_urban.F @@ -1133,7 +1133,7 @@ SUBROUTINE urban(LSOLAR, & ! L CALL TDFCND (DF1,SMR(KZ), QUARTZ, SMCMAX ) DF1 = DF1 * EXP(-2.0 * SHDFAC) - RGR = EPSV*(RX-SIG*(TGRP**4.)/60.) + RGR = EPSV*(RX-SIG*(TA**4.)/60.) RGRR= (SGR+RGR) * 697.7 * 60. RCH = RHOO*CPP*CHGR RR1 = EPSV*(TA**4) * 6.48E-8 / (PS* CHGR) + 1.0 @@ -1635,7 +1635,7 @@ SUBROUTINE mos(XXX,ALPHA,CD,B1,RIB,Z,Z0,UA,TA,TSF,RHO) PSIM=ALOG((Z+Z0)/Z0) & -ALOG((X+1.)**2.*(X**2.+1.)) & +2.*ATAN(X) & - +ALOG((X+1.)**2.*(X0**2.+1.)) & + +ALOG((X0+1.)**2.*(X0**2.+1.)) & -2.*ATAN(X0) FAIH=1./SQRT(1.-16.*XXX) PSIH=ALOG((Z+Z0)/Z0)+0.4*B1 & From 8805bc1508239081394dac42f1989fe98e99c645 Mon Sep 17 00:00:00 2001 From: cenlinhe Date: Wed, 29 Jan 2025 13:20:29 -0700 Subject: [PATCH 2/5] bug fix for heat transfer coefficient correlation parameters in BEM --- urban/wrf/module_sf_bem.F | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/urban/wrf/module_sf_bem.F b/urban/wrf/module_sf_bem.F index 2a632fa..bd6db4a 100644 --- a/urban/wrf/module_sf_bem.F +++ b/urban/wrf/module_sf_bem.F @@ -882,7 +882,7 @@ subroutine hsfluxpv(nz,n,bl,bw,albr,rs,swddif,emr,rl,tr,tair,sigma,hspv,eppv,pv_ uroof=(uout(n+1)**2+vout(n+1)**2)**0.5 deltat=tpv-tair(n+1) hf=2.5*(40./100.*uroof)**(0.5) - hc=9.842*abs(deltat)**(1./3.)/(7.283-abs(cos(tiltangle))) + hc=9.482*abs(deltat)**(1./3.)/(7.238-abs(cos(tiltangle))) hup=sqrt(hc**2.+(hf)**2.) hc=1.810*abs(deltat)**(1./3.)/(1.382+abs(cos(tiltangle))) hdown=sqrt(hc**2.+(hf)**2.) From 07a70ed2d4c6157c9a715fcb411c9c8cc08e5e2e Mon Sep 17 00:00:00 2001 From: cenlinhe Date: Wed, 29 Jan 2025 13:28:33 -0700 Subject: [PATCH 3/5] Corrected LECH stability functions in SLUCM --- urban/wrf/module_sf_urban.F | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/urban/wrf/module_sf_urban.F b/urban/wrf/module_sf_urban.F index 8168496..af4a6b4 100644 --- a/urban/wrf/module_sf_urban.F +++ b/urban/wrf/module_sf_urban.F @@ -3057,13 +3057,13 @@ SUBROUTINE SFCDIF_URB (ZLM,Z0,THZ0,THLM,SFCSPD,AKANDA,AKMS,AKHS,RLMO,CD) ! LECH'S SURFACE FUNCTIONS ! ---------------------------------------------------------------------- PSLMU (ZZ)= -0.96* log (1.0-4.5* ZZ) - PSLMS (ZZ)= ZZ * RRIC -2.076* (1. -1./ (ZZ +1.)) + PSLMS (ZZ)= (ZZ/RFC) -2.076* (1. -1./ (ZZ +1.)) PSLHU (ZZ)= -0.96* log (1.0-4.5* ZZ) ! ---------------------------------------------------------------------- ! PAULSON'S SURFACE FUNCTIONS ! ---------------------------------------------------------------------- - PSLHS (ZZ)= ZZ * RFAC -2.076* (1. -1./ (ZZ +1.)) + PSLHS (ZZ)= ZZ * RFAC -2.076* (1. - exp(-1.2 * ZZ)) PSPMU (XX)= -2.* log ( (XX +1.)*0.5) - log ( (XX * XX +1.)*0.5) & & +2.* ATAN (XX) & &- PIHF From 21b77eb82776ba275c00de1b4ccc93075f0293f8 Mon Sep 17 00:00:00 2001 From: cenlinhe Date: Wed, 29 Jan 2025 13:33:54 -0700 Subject: [PATCH 4/5] bug fix for missing reflected radiation reflection from the wall in SLUCM --- urban/wrf/module_sf_urban.F | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/urban/wrf/module_sf_urban.F b/urban/wrf/module_sf_urban.F index af4a6b4..9c3cff5 100644 --- a/urban/wrf/module_sf_urban.F +++ b/urban/wrf/module_sf_urban.F @@ -877,7 +877,7 @@ SUBROUTINE urban(LSOLAR, & ! L SG1=SX*VFGS*(1.-ALBG) SB1=SX*VFWS*(1.-ALBB) SG2=SB1*ALBB/(1.-ALBB)*VFGW*(1.-ALBG) - SB2=SG1*ALBG/(1.-ALBG)*VFWG*(1.-ALBB) + SB2=SG1*ALBG/(1.-ALBG)*VFWG*(1.-ALBB) + SB1*ALBB*VFWW ELSE ! shadow effects model @@ -923,7 +923,7 @@ SUBROUTINE urban(LSOLAR, & ! L SG1=SD*(RW-SLX)/RW*(1.-ALBG)+SQ*VFGS*(1.-ALBG) SB1=SD*SLX/W*(1.-ALBB)+SQ*VFWS*(1.-ALBB) SG2=SB1*ALBB/(1.-ALBB)*VFGW*(1.-ALBG) - SB2=SG1*ALBG/(1.-ALBG)*VFWG*(1.-ALBB) + SB2=SG1*ALBG/(1.-ALBG)*VFWG*(1.-ALBB) + SB1*ALBB*VFWW END IF From 273df1ca8b5a90beb19e79edbbc794dfca7166b8 Mon Sep 17 00:00:00 2001 From: cenlinhe Date: Wed, 29 Jan 2025 16:29:09 -0700 Subject: [PATCH 5/5] sync with Noah-MP source code for recent bug fix --- noahmp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/noahmp b/noahmp index c7a04d8..5a94459 160000 --- a/noahmp +++ b/noahmp @@ -1 +1 @@ -Subproject commit c7a04d8c6d4b9533a6b99c72229ed9279fe39e46 +Subproject commit 5a9445945bb84e3bae70ed7f10ca6c9540a88e99