Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Performance Optimization #234

Open
shaomeng opened this issue Mar 31, 2024 · 0 comments
Open

Possible Performance Optimization #234

shaomeng opened this issue Mar 31, 2024 · 0 comments
Labels
performance Opportunities to improve the runtime performance

Comments

@shaomeng
Copy link
Contributor

shaomeng commented Mar 31, 2024

  1. It appears that the NewlySig enum is unnecessary.
  2. Consider refine all data points all together, and use a bitmask to save the output of whether individual points are significant or not. This is equivalent to the current approach, but I suspect that it's gonna be faster.
    • To clarify, in the current code, a data point is refined first in the m_process_P or m_process_P_lite routine, and then repeatedly in the m_refinement_pass routine.
    • On the one hand, it should be helpful to really refine the data buffer in only one place, and simply use a bitmask to keep necessary information in other places.
    • On the other hand, a significant data point is already located, so refining it wouldn't cost another random access. The benefit of this approach really needs to be evaluated.
@shaomeng shaomeng changed the title A few things to consider Possible Performance Optimization Aug 23, 2024
@shaomeng shaomeng added the performance Opportunities to improve the runtime performance label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Opportunities to improve the runtime performance
Projects
None yet
Development

No branches or pull requests

1 participant