Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URI creation from path #16

Closed
aeschli opened this issue Aug 27, 2018 · 2 comments
Closed

Fix URI creation from path #16

aeschli opened this issue Aug 27, 2018 · 2 comments

Comments

@aeschli
Copy link

aeschli commented Aug 27, 2018

In 1.26 we discovered that several extensions call the 'vscode.openFolder' command with invalid file URIs:

  • NAVBaaS.git/out/commands/Go.js
    136,51: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(gitRepoFolder));
  • NAVBaaS.git/out/commands/openGitRepoFolder.js
    27,51: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(gitRepoFolder));
  • NAVBaaS.git/out/commands/openWorkspace.js
    27,51: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(gitRepoFolder));

When creating a URI from a file path, always use vscode.URI.file(path), e.g vscode.URI.file('c:\\test')
Use vscode.URI.parse(uriString) when the input string is in the form scheme://authority/path

See microsoft/vscode#57267 for more information or for questions.

@richardrobberse
Copy link
Contributor

Thanks for letting me know, will fix it asap!

@richardrobberse
Copy link
Contributor

Fixed in version 1.6.2, will be on the marketplace within a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants