Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve remote testing on PRs #355

Open
mkelley opened this issue Jul 6, 2022 · 2 comments
Open

Resolve remote testing on PRs #355

mkelley opened this issue Jul 6, 2022 · 2 comments
Labels

Comments

@mkelley
Copy link
Member

mkelley commented Jul 6, 2022

As noted in #345 , we cannot use the NASA ADS API without publicly exposing a secret API key. These tests could be restored if the ads-based tests could be skipped (perhaps using a pytest.mark or a test that the key exists), or if the ads module was used in sandbox mode. Or may be use a combination of the two?

@mkelley mkelley added the tests label Jul 6, 2022
@jianyangli
Copy link
Contributor

I thought you used the GitHub repository secret to save the ADS key and allow for tests using secret keys. Perhaps I missed something?

@mkelley
Copy link
Member Author

mkelley commented Jul 24, 2022

Sorry, I mean for this to be specific to pull requests. We can indeed use the API key with our weekly tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants