-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Require autodiscovery gbfs.json file, define feed names #189
Proposal: Require autodiscovery gbfs.json file, define feed names #189
Conversation
I've updated this proposal to say that the I think this is ready for a vote! I hereby call a vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on Monday, Nov 25. |
This seems like a weird requirement - if we're not dictating the path structure, then knowing that the GBFS file is named I agree that we should require the file so the rest of the paths can be discoverable, but as long as someone points to the file either from the |
Yes, that's a fair criticism. I was on the fence about which way to specify this, and initially leaned towards requiring I'll revise this to say that |
Ok, I've revised this based on @jcn's feedback. I'd like to re-start the vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on Monday, Nov 25. Please vote for or against the proposal to require the auto-discovery file and define the feed names, and include the organization for which you are voting in your comment. |
+1 from IBI Group |
Voting on this proposal is now closed. There was 1 in favor. @antrim @heidiguenin What's the minimum vote threshold for a proposal in GBFS? |
The previous vote didn't get enough participation. We have clarified the process for the governance pilot, and we're hoping for more input this time around - #163 (comment). I hereby call a vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on December 6th. Please vote for or against the proposal to require the auto-discovery file and define the feed names, and include the organization for which you are voting in your comment. |
+1 from Transit |
@barbeau can you fix the merge conflicts real quick, please? |
@evansiroky The merge conflicts are fixed (thanks to @antrim a few days ago). Please vote! |
+1 from IBI Group |
Voting on this proposal closes tomorrow, 11:59PM UTC on December 6th. So far we have 2 "yes" votes, and we need one more for it to be adopted. Please review and vote! cc @jcn |
+1 from Stae |
+1 from Transit |
The vote is closed and it passes! 3 votes for:
...and no votes against. I'm going to wait to merge until we conclude the discussion at #163. |
(I'm commenting on this old PR because it introduced the sentence I have a question about. Let me know if I should open a new Issue to clarify this.)
Does this mean that the URLs/IRLs can be relative, as in they don't have to be absolute? I would argue strongly in favour of explicitly allowing relative URLs, given that
|
Thank you @derhuerst for your question! |
I have created #544 to discuss this. |
This is a proposal to address #139, which includes requiring the autodiscovery gbfs.json file and establishing a clear convention for the feed names within the autodiscovery file.
Open questions:
Do we requiregbfs.json
to be namedgbfs.json
? Or is a path like/gbfs
allowed for auto-discovery?EDIT Nov 18, 2019 - Add text requiring that
gbfs.json
be namedgbfs.json
.EDIT Nov 18, 2019 - Remove text requiring that
gbfs.json
be namedgbfs.json
- it can be named whatever you want.