diff --git a/narwhal/network/src/p2p.rs b/narwhal/network/src/p2p.rs index 2bf2442b5962f..b7ff87d545bdb 100644 --- a/narwhal/network/src/p2p.rs +++ b/narwhal/network/src/p2p.rs @@ -6,7 +6,7 @@ use crate::{ traits::{Lucky, ReliableNetwork, UnreliableNetwork}, BoundedExecutor, CancelOnDropHandler, RetryConfig, MAX_TASK_CONCURRENCY, }; -use anemo::{Peer, PeerId, Response}; +use anemo::PeerId; use anyhow::format_err; use anyhow::Result; use async_trait::async_trait; @@ -18,11 +18,10 @@ use tokio::{runtime::Handle, task::JoinHandle}; use types::{ Batch, BatchDigest, FetchCertificatesRequest, FetchCertificatesResponse, GetCertificatesRequest, GetCertificatesResponse, LatestHeaderRequest, LatestHeaderResponse, - PrimaryMessage, PrimaryToPrimaryClient, PrimaryToPrimaryClient, PrimaryToWorkerClient, - PrimaryToWorkerClient, RequestBatchRequest, WorkerBatchMessage, WorkerDeleteBatchesMessage, - WorkerOthersBatchMessage, WorkerOurBatchMessage, WorkerReconfigureMessage, - WorkerSynchronizeMessage, WorkerToPrimaryClient, WorkerToPrimaryClient, WorkerToWorkerClient, - WorkerToWorkerClient, + PrimaryMessage, PrimaryToPrimaryClient, PrimaryToWorkerClient, RequestBatchRequest, + WorkerBatchMessage, WorkerDeleteBatchesMessage, WorkerOthersBatchMessage, + WorkerOurBatchMessage, WorkerReconfigureMessage, WorkerSynchronizeMessage, + WorkerToPrimaryClient, WorkerToWorkerClient, }; fn default_executor() -> BoundedExecutor { diff --git a/narwhal/primary/src/core.rs b/narwhal/primary/src/core.rs index 6ed8788ed9876..965ef1c186f8b 100644 --- a/narwhal/primary/src/core.rs +++ b/narwhal/primary/src/core.rs @@ -15,9 +15,7 @@ use crypto::{NetworkPublicKey, PublicKey, Signature}; use fastcrypto::{hash::Hash as _, SignatureService}; use futures::stream::FuturesUnordered; use futures::StreamExt; -use network::{ - CancelOnDropHandler, P2pNetwork, PrimaryToPrimaryRpc, ReliableNetwork, UnreliableNetwork, -}; +use network::{CancelOnDropHandler, P2pNetwork, PrimaryToPrimaryRpc, ReliableNetwork}; use std::time::Duration; use std::{ collections::{HashMap, HashSet}, @@ -33,8 +31,8 @@ use types::{ ensure, error::{DagError, DagError::StoreError, DagResult}, metered_channel::{Receiver, Sender}, - Certificate, Header, HeaderDigest, LatestHeaderRequest, PrimaryToPrimaryClient, - ReconfigureNotification, Round, RoundVoteDigestPair, Timestamp, Vote, + Certificate, Header, HeaderDigest, LatestHeaderRequest, ReconfigureNotification, Round, + RoundVoteDigestPair, Timestamp, Vote, }; #[cfg(test)] @@ -207,7 +205,7 @@ impl Core { }); } let request_interval = Duration::from_secs(RECOVERY_REQUEST_TIMEOUT_SECS); - let interval = Box::pin(time::sleep(request_interval)); + let mut interval = Box::pin(time::sleep(request_interval)); loop { tokio::select! { res = header_futures.next() => { diff --git a/narwhal/primary/src/primary.rs b/narwhal/primary/src/primary.rs index d958ff0953afc..38885bfadb055 100644 --- a/narwhal/primary/src/primary.rs +++ b/narwhal/primary/src/primary.rs @@ -56,10 +56,11 @@ use types::{ FetchCertificatesResponse, GetCertificatesRequest, GetCertificatesResponse, Header, HeaderDigest, LatestHeaderRequest, LatestHeaderResponse, PayloadAvailabilityRequest, PayloadAvailabilityResponse, PrimaryToPrimary, PrimaryToPrimary, PrimaryToPrimary, - PrimaryToPrimaryServer, PrimaryToPrimaryServer, PrimaryToPrimaryServer, - ReconfigureNotification, Round, RoundVoteDigestPair, WorkerInfoResponse, - WorkerOthersBatchMessage, WorkerOurBatchMessage, WorkerToPrimary, WorkerToPrimary, - WorkerToPrimary, WorkerToPrimaryServer, WorkerToPrimaryServer, WorkerToPrimaryServer, + PrimaryToPrimary, PrimaryToPrimaryServer, PrimaryToPrimaryServer, PrimaryToPrimaryServer, + PrimaryToPrimaryServer, ReconfigureNotification, Round, RoundVoteDigestPair, + WorkerInfoResponse, WorkerOthersBatchMessage, WorkerOurBatchMessage, WorkerToPrimary, + WorkerToPrimary, WorkerToPrimary, WorkerToPrimary, WorkerToPrimaryServer, + WorkerToPrimaryServer, WorkerToPrimaryServer, WorkerToPrimaryServer, }; #[cfg(any(test))] diff --git a/narwhal/primary/src/proposer.rs b/narwhal/primary/src/proposer.rs index 762011d575b39..b4eec0423a428 100644 --- a/narwhal/primary/src/proposer.rs +++ b/narwhal/primary/src/proposer.rs @@ -18,8 +18,7 @@ use tracing::{debug, info}; use types::{ error::{DagError, DagResult}, metered_channel::{Receiver, Sender}, - BatchDigest, Certificate, Header, PrimaryMessage, ReconfigureNotification, Round, Timestamp, - TimestampMs, + BatchDigest, Certificate, Header, ReconfigureNotification, Round, Timestamp, TimestampMs, }; #[cfg(test)] diff --git a/narwhal/primary/src/tests/certificate_waiter_tests.rs b/narwhal/primary/src/tests/certificate_waiter_tests.rs index 9c1976eb42ddd..27c8029165bee 100644 --- a/narwhal/primary/src/tests/certificate_waiter_tests.rs +++ b/narwhal/primary/src/tests/certificate_waiter_tests.rs @@ -31,8 +31,8 @@ use types::{ BatchDigest, Certificate, CertificateDigest, FetchCertificatesRequest, FetchCertificatesResponse, GetCertificatesRequest, GetCertificatesResponse, Header, HeaderDigest, LatestHeaderRequest, LatestHeaderResponse, Metadata, PayloadAvailabilityRequest, - PayloadAvailabilityResponse, PrimaryMessage, PrimaryToPrimary, PrimaryToPrimary, - PrimaryToPrimaryServer, PrimaryToPrimaryServer, ReconfigureNotification, Round, + PayloadAvailabilityResponse, PrimaryMessage, PrimaryToPrimary, PrimaryToPrimaryServer, + ReconfigureNotification, Round, }; struct FetchCertificateProxy { @@ -75,7 +75,7 @@ impl PrimaryToPrimary for FetchCertificateProxy { &self, _request: anemo::Request, ) -> Result, anemo::rpc::Status> { - unimplemented!() + Ok(anemo::Response::new(LatestHeaderResponse { header: None })) } } diff --git a/narwhal/primary/src/tests/proposer_tests.rs b/narwhal/primary/src/tests/proposer_tests.rs index b049130d7d44c..2edf1b7362516 100644 --- a/narwhal/primary/src/tests/proposer_tests.rs +++ b/narwhal/primary/src/tests/proposer_tests.rs @@ -180,7 +180,6 @@ async fn equivocation_protection() { // Ensure the proposer makes a correct header from the provided payload. let header = rx_headers.recv().await.unwrap(); - assert_eq!(header.round, 2); assert_eq!(header.payload.get(&digest), Some(&worker_id)); assert!(header.verify(&committee, shared_worker_cache).is_ok()); diff --git a/narwhal/test-utils/src/lib.rs b/narwhal/test-utils/src/lib.rs index c127a0f4c734a..9a1043980ada8 100644 --- a/narwhal/test-utils/src/lib.rs +++ b/narwhal/test-utils/src/lib.rs @@ -27,13 +27,11 @@ use tracing::info; use types::{ Batch, BatchDigest, Certificate, CertificateDigest, ConsensusStore, FetchCertificatesRequest, FetchCertificatesResponse, GetCertificatesRequest, GetCertificatesResponse, Header, - HeaderBuilder, HeaderBuilder, LatestHeaderRequest, LatestHeaderResponse, - PayloadAvailabilityRequest, PayloadAvailabilityResponse, PrimaryMessage, PrimaryToPrimary, - PrimaryToPrimary, PrimaryToPrimaryServer, PrimaryToPrimaryServer, PrimaryToWorker, - PrimaryToWorker, PrimaryToWorkerServer, PrimaryToWorkerServer, RequestBatchRequest, - RequestBatchResponse, Round, SequenceNumber, Transaction, Vote, WorkerBatchMessage, - WorkerDeleteBatchesMessage, WorkerReconfigureMessage, WorkerSynchronizeMessage, WorkerToWorker, - WorkerToWorker, WorkerToWorkerServer, WorkerToWorkerServer, + HeaderBuilder, LatestHeaderRequest, LatestHeaderResponse, PayloadAvailabilityRequest, + PayloadAvailabilityResponse, PrimaryMessage, PrimaryToPrimary, PrimaryToPrimaryServer, + PrimaryToWorker, PrimaryToWorkerServer, RequestBatchRequest, RequestBatchResponse, Round, + SequenceNumber, Transaction, Vote, WorkerBatchMessage, WorkerDeleteBatchesMessage, + WorkerReconfigureMessage, WorkerSynchronizeMessage, WorkerToWorker, WorkerToWorkerServer, }; pub mod cluster; diff --git a/narwhal/types/build.rs b/narwhal/types/build.rs index 824dab391c434..648fd343c8fdc 100644 --- a/narwhal/types/build.rs +++ b/narwhal/types/build.rs @@ -1,7 +1,6 @@ // Copyright (c) Mysten Labs, Inc. // SPDX-License-Identifier: Apache-2.0 -use rustversion::{beta, nightly, stable}; use std::{ env, path::{Path, PathBuf},