Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto Scrolling Container #545

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Add Auto Scrolling Container #545

merged 3 commits into from
Mar 17, 2024

Conversation

MyreMylar
Copy link
Owner

Step 8 of splitting mega-PR #494 into smaller easier to review PRs

Step 8 of splitting mega-PR #494 into smaller easier to review PRs

Co-authored-by: GimLala <[email protected]>
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (2081310) to head (b8b51fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
+ Coverage   96.23%   96.24%   +0.01%     
==========================================
  Files          87       88       +1     
  Lines       12416    12452      +36     
==========================================
+ Hits        11949    11985      +36     
  Misses        467      467              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MyreMylar
Copy link
Owner Author

MyreMylar commented Mar 16, 2024

I'm probably going to merge this as it is for now I think (once I've improved the tests and tested it out in some examples) - but I want to consider before the next version release whether it worth merging this wholly into the vanilla UIScrolllingContainer rather than having both a UIScrollingContainer and a UIAutoScrollingContainer.

The question is if there are benefits to having the split or not. Do users want manual control over scrolling behaviour of scrollable containers - even if they do, can we accommodate that cleanly in one element rather than two....

@MyreMylar MyreMylar mentioned this pull request Mar 16, 2024
9 tasks
MyreMylar and others added 2 commits March 17, 2024 19:21
Step 8 of splitting mega-PR #494 into smaller easier to review PRs

Co-authored-by: GimLala <[email protected]>
Step 8 of splitting mega-PR #494 into smaller easier to review PRs

Co-authored-by: GimLala <[email protected]>
@MyreMylar MyreMylar merged commit 08924ab into main Mar 17, 2024
22 checks passed
@MyreMylar MyreMylar deleted the add-auto-scrolling-container branch April 1, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant