Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes & tests to improve coverage & resolve bugs related to untested code #280

Merged
merged 9 commits into from
Jul 19, 2022

Conversation

MyreMylar
Copy link
Owner

Testing coverage was dropping a bit over recent release so I thought I'd exert some effort to improve it as it usually turns up a few bugs.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #280 (d864b8f) into main (12d7122) will increase coverage by 1.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   91.38%   92.42%   +1.03%     
==========================================
  Files          70       70              
  Lines        9698     9691       -7     
==========================================
+ Hits         8863     8957      +94     
+ Misses        835      734     -101     
Impacted Files Coverage Δ
pygame_gui/elements/ui_vertical_scroll_bar.py 100.00% <100.00%> (+5.41%) ⬆️
pygame_gui/windows/ui_colour_picker_dialog.py 95.02% <100.00%> (+2.01%) ⬆️
pygame_gui/windows/ui_file_dialog.py 87.38% <100.00%> (+4.28%) ⬆️
pygame_gui/core/ui_element.py 95.83% <0.00%> (+0.46%) ⬆️
pygame_gui/core/ui_font_dictionary.py 92.64% <0.00%> (+1.47%) ⬆️
pygame_gui/elements/ui_image.py 96.42% <0.00%> (+7.14%) ⬆️
pygame_gui/ui_manager.py 92.18% <0.00%> (+7.81%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d7122...d864b8f. Read the comment docs.

@MyreMylar MyreMylar merged commit b10c84d into main Jul 19, 2022
@MyreMylar MyreMylar deleted the coverage-fixes branch August 5, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant