Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a combination of drawable_shape #516

Open
LondonClass opened this issue Feb 15, 2024 · 1 comment
Open

Add a combination of drawable_shape #516

LondonClass opened this issue Feb 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@LondonClass
Copy link
Contributor

The drawable shape combination can bind a set of drawable shapes together and operate like a separate drawable shape. This way, complex shapes can be achieved by combining drawable_shape.

Actually, it may be a good idea to divide the text and image parts of drawable_shape into two parts.

@MyreMylar
Copy link
Owner

MyreMylar commented Feb 26, 2024

Text and image are already pretty separate right now so I expect this could be refactored reasonably easily. Text happens mostly in it's own submodule and gets drawn on top at the end.

You could probably define a new DrawableShape that was a combination of any underlying shapes you want, the base shape drawing part isn't that tough and follows a pretty similar process for circles, rectangles and rounded rectangles. IIRC there are a few optimisations here and there depending on the base shape, but if you wanted triangular shapes or star shapes it should all be doable, maybe a basic filled polygon shape is the way to go to cover lots of bases?

@MyreMylar MyreMylar added the enhancement New feature or request label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants