Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Improve API for WAMP message options #36

Open
danmarcab opened this issue Aug 5, 2015 · 0 comments
Open

Improve API for WAMP message options #36

danmarcab opened this issue Aug 5, 2015 · 0 comments

Comments

@danmarcab
Copy link
Contributor

Right now, if we want to pass options to the wamp message we have to use an options key:

{:ok, subscription} = Spell.call_subscribe(subscriber, "com.spell.my_topic_prefix", options: %{match: :prefix})

Quoting @jtmoulia
The justification for having an specific options keyword arg is that it maps directly to the WAMP message's options argument.

A suggestion to improve the API, would be:

Spell.call_subscribe(subscriber, "com.spell.my_topic_prefix", match: :prefix)

See #35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant