Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginLoaders not found for platform specific plugins #2611

Closed
Cheesebaron opened this issue Feb 12, 2018 · 0 comments · Fixed by #2603
Closed

PluginLoaders not found for platform specific plugins #2611

Cheesebaron opened this issue Feb 12, 2018 · 0 comments · Fixed by #2603
Labels
p/plugins Plugins platform t/bug Bug type
Milestone

Comments

@Cheesebaron
Copy link
Member

MvxAndroidSetup and the other platform setups look for a specific extension to the plugin assembly. So for Android it expects an assembly that is called MyPlugin.Useful.Droid where the Android implementation resides. If it doesn't find that, it doesn't try to fall back to anything else and then just explodes.

This happens due to when switching to Multi-target, the assembly names are now all the same for all assemblies. Platform specific or not.

@AlexStefan was very quick to provide a repro sample https://github.com/AlexStefan/template-app/blob/master/Internationalization/

The Core and Droid projects there point at MvvmCross in the folder ../../mc

Steps to reproduce 📜

  1. Add one of the official plugins
  2. Make sure Bootstrap is added
  3. Load a ViewModel which uses that plugin
  4. 💥 app crashes

Expected behavior 🤔

App should run

Actual behavior 🐛

App crashes

Configuration 🔧

Version: 6.0.0-beta2

@Cheesebaron Cheesebaron added the t/bug Bug type label Feb 12, 2018
@nmilcoff nmilcoff added the p/plugins Plugins platform label Feb 13, 2018
@nmilcoff nmilcoff added this to the 6.0.0 milestone Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/plugins Plugins platform t/bug Bug type
Development

Successfully merging a pull request may close this issue.

2 participants