Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation service: ChangePresentation should be async #2602

Closed
softlion opened this issue Feb 11, 2018 · 0 comments · Fixed by #2604
Closed

Navigation service: ChangePresentation should be async #2602

softlion opened this issue Feb 11, 2018 · 0 comments · Fixed by #2604
Milestone
6.0.0

Comments

@softlion
Copy link
Contributor

softlion commented Feb 11, 2018 •
edited
Loading

ChangePresentation is like any other Navigation methods: the presenter will take some time to achieve its work. So it should also returns a Task, like the Navigate() method.

Steps to reproduce 📜

Navigation.ChangePresentation(hint) return a bool

Expected behavior 🤔

Navigation.ChangePresentation(hint) should return a Task instead

Configuration 🔧

Version: 5.6.3

Platform:
All
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Make ChangePresentation signature async martijn00/MvvmCross
2 participants
@softlion @martijn00