Skip to content

Commit 9a99995

Browse files
MurhafSousliMurhafSousli
committed
Update
1 parent 1f38295 commit 9a99995

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+5457
-4504
lines changed

‎.browserslistrc

-12
This file was deleted.

‎.editorconfig

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Editor configuration, see http://editorconfig.org
1+
# Editor configuration, see https://editorconfig.org
22
root = true
33

44
[*]
@@ -8,6 +8,9 @@ indent_size = 2
88
insert_final_newline = true
99
trim_trailing_whitespace = true
1010

11+
[*.ts]
12+
quote_type = single
13+
1114
[*.md]
1215
max_line_length = off
1316
trim_trailing_whitespace = false

‎.eslintrc.json

+47
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
{
2+
"root": true,
3+
"ignorePatterns": [
4+
"projects/**/*"
5+
],
6+
"overrides": [
7+
{
8+
"files": [
9+
"*.ts"
10+
],
11+
"extends": [
12+
"eslint:recommended",
13+
"plugin:@typescript-eslint/recommended",
14+
"plugin:@angular-eslint/recommended",
15+
"plugin:@angular-eslint/template/process-inline-templates"
16+
],
17+
"rules": {
18+
"@angular-eslint/directive-selector": [
19+
"error",
20+
{
21+
"type": "attribute",
22+
"prefix": "app",
23+
"style": "camelCase"
24+
}
25+
],
26+
"@angular-eslint/component-selector": [
27+
"error",
28+
{
29+
"type": "element",
30+
"prefix": "app",
31+
"style": "kebab-case"
32+
}
33+
]
34+
}
35+
},
36+
{
37+
"files": [
38+
"*.html"
39+
],
40+
"extends": [
41+
"plugin:@angular-eslint/template/recommended",
42+
"plugin:@angular-eslint/template/accessibility"
43+
],
44+
"rules": {}
45+
}
46+
]
47+
}

‎.github/workflows/netlify.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Install dependencies
1717
run: npm ci
1818
- name: Build demo
19-
run: npm run build-demo
19+
run: npm run build
2020
- name: Deploy to Netlify
2121
uses: nwtgck/actions-netlify@v3.0.0
2222
with:

‎.gitignore

+11-9
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,42 @@
11
# See http://help.github.com/ignore-files/ for more about ignoring files.
22

3-
# compiled output
3+
# Compiled output
44
/dist
55
/tmp
66
/out-tsc
7+
/bazel-out
78

8-
# dependencies
9+
# Node
910
/node_modules
11+
npm-debug.log
12+
yarn-error.log
1013

1114
# IDEs and editors
12-
/.idea
15+
.idea/
1316
.project
1417
.classpath
1518
.c9/
1619
*.launch
1720
.settings/
1821
*.sublime-workspace
1922

20-
# IDE - VSCode
23+
# Visual Studio Code
2124
.vscode/*
2225
!.vscode/settings.json
2326
!.vscode/tasks.json
2427
!.vscode/launch.json
2528
!.vscode/extensions.json
29+
.history/*
2630

27-
# misc
31+
# Miscellaneous
2832
/.angular/cache
29-
/.sass-cache
33+
.sass-cache/
3034
/connect.lock
3135
/coverage
3236
/libpeerconnection.log
33-
npm-debug.log
34-
yarn-error.log
3537
testem.log
3638
/typings
3739

38-
# System Files
40+
# System files
3941
.DS_Store
4042
Thumbs.db

‎CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 14.0.0
4+
5+
- Upgrade to Angular 19 (still compatible v17.3.0 and above).
6+
- fix: `ngProgressHttp` gives an error with http requests inside effects, closes [#386](https://github.com/MurhafSousli/ngx-progressbar/issues/386)
7+
38
## 13.0.0
49

510
- feat: `NgProgressRef` directive has `(started)` and `(completed)` outputs, instead of subjects.

‎angular.json

+73-66
Original file line numberDiff line numberDiff line change
@@ -3,34 +3,6 @@
33
"version": 1,
44
"newProjectRoot": "projects",
55
"projects": {
6-
"ngx-progressbar": {
7-
"projectType": "library",
8-
"root": "projects/ngx-progressbar",
9-
"sourceRoot": "projects/ngx-progressbar/src",
10-
"prefix": "lib",
11-
"architect": {
12-
"build": {
13-
"builder": "@angular-devkit/build-angular:ng-packagr",
14-
"options": {
15-
"tsConfig": "projects/ngx-progressbar/tsconfig.lib.json",
16-
"project": "projects/ngx-progressbar/ng-package.json"
17-
},
18-
"configurations": {
19-
"production": {
20-
"tsConfig": "projects/ngx-progressbar/tsconfig.lib.prod.json"
21-
}
22-
}
23-
},
24-
"test": {
25-
"builder": "@angular-devkit/build-angular:karma",
26-
"options": {
27-
"main": "projects/ngx-progressbar/src/test.ts",
28-
"tsConfig": "projects/ngx-progressbar/tsconfig.spec.json",
29-
"karmaConfig": "projects/ngx-progressbar/karma.conf.js"
30-
}
31-
}
32-
}
33-
},
346
"ngx-progressbar-demo": {
357
"projectType": "application",
368
"schematics": {
@@ -45,14 +17,14 @@
4517
"build": {
4618
"builder": "@angular-devkit/build-angular:application",
4719
"options": {
48-
"outputPath": {
49-
"base": "dist/ngx-progressbar-demo"
50-
},
20+
"outputPath": "dist/ngx-progressbar-demo",
5121
"index": "projects/ngx-progressbar-demo/src/index.html",
22+
"browser": "projects/ngx-progressbar-demo/src/main.ts",
5223
"polyfills": [
53-
"projects/ngx-progressbar-demo/src/polyfills.ts"
24+
"zone.js"
5425
],
5526
"tsConfig": "projects/ngx-progressbar-demo/tsconfig.app.json",
27+
"inlineStyleLanguage": "scss",
5628
"assets": [
5729
"projects/ngx-progressbar-demo/src/favicon.ico",
5830
"projects/ngx-progressbar-demo/src/assets"
@@ -61,50 +33,47 @@
6133
"projects/ngx-progressbar-demo/src/styles.scss"
6234
],
6335
"scripts": [],
64-
"extractLicenses": false,
65-
"sourceMap": true,
66-
"optimization": false,
67-
"namedChunks": true,
68-
"browser": "projects/ngx-progressbar-demo/src/main.ts"
36+
"server": "projects/ngx-progressbar-demo/src/main.server.ts",
37+
"prerender": true,
38+
"ssr": {
39+
"entry": "projects/ngx-progressbar-demo/src/server.ts"
40+
}
6941
},
7042
"configurations": {
7143
"production": {
72-
"fileReplacements": [
73-
{
74-
"replace": "projects/ngx-progressbar-demo/src/environments/environment.ts",
75-
"with": "projects/ngx-progressbar-demo/src/environments/environment.prod.ts"
76-
}
77-
],
78-
"optimization": true,
79-
"outputHashing": "all",
80-
"sourceMap": false,
81-
"namedChunks": false,
82-
"extractLicenses": true,
8344
"budgets": [
8445
{
8546
"type": "initial",
8647
"maximumWarning": "2mb",
87-
"maximumError": "5mb"
48+
"maximumError": "3mb"
8849
},
8950
{
9051
"type": "anyComponentStyle",
91-
"maximumWarning": "6kb",
92-
"maximumError": "10kb"
52+
"maximumWarning": "15kb",
53+
"maximumError": "15kb"
9354
}
94-
]
55+
],
56+
"outputHashing": "all"
57+
},
58+
"development": {
59+
"optimization": false,
60+
"extractLicenses": false,
61+
"sourceMap": true
9562
}
96-
}
63+
},
64+
"defaultConfiguration": "production"
9765
},
9866
"serve": {
9967
"builder": "@angular-devkit/build-angular:dev-server",
100-
"options": {
101-
"buildTarget": "ngx-progressbar-demo:build"
102-
},
10368
"configurations": {
10469
"production": {
10570
"buildTarget": "ngx-progressbar-demo:build:production"
71+
},
72+
"development": {
73+
"buildTarget": "ngx-progressbar-demo:build:development"
10674
}
107-
}
75+
},
76+
"defaultConfiguration": "development"
10877
},
10978
"extract-i18n": {
11079
"builder": "@angular-devkit/build-angular:extract-i18n",
@@ -115,10 +84,12 @@
11584
"test": {
11685
"builder": "@angular-devkit/build-angular:karma",
11786
"options": {
118-
"main": "projects/ngx-progressbar-demo/src/test.ts",
119-
"polyfills": "projects/ngx-progressbar-demo/src/polyfills.ts",
87+
"polyfills": [
88+
"zone.js",
89+
"zone.js/testing"
90+
],
12091
"tsConfig": "projects/ngx-progressbar-demo/tsconfig.spec.json",
121-
"karmaConfig": "projects/ngx-progressbar-demo/karma.conf.js",
92+
"inlineStyleLanguage": "scss",
12293
"assets": [
12394
"projects/ngx-progressbar-demo/src/favicon.ico",
12495
"projects/ngx-progressbar-demo/src/assets"
@@ -128,20 +99,56 @@
12899
],
129100
"scripts": []
130101
}
131-
},
132-
"e2e": {
133-
"builder": "@angular-devkit/build-angular:protractor",
102+
}
103+
}
104+
},
105+
"ngx-progressbar": {
106+
"projectType": "library",
107+
"root": "projects/ngx-progressbar",
108+
"sourceRoot": "projects/ngx-progressbar/src",
109+
"prefix": "lib",
110+
"architect": {
111+
"build": {
112+
"builder": "@angular-devkit/build-angular:ng-packagr",
134113
"options": {
135-
"protractorConfig": "projects/ngx-progressbar-demo/e2e/protractor.conf.js",
136-
"devServerTarget": "ngx-progressbar-demo:serve"
114+
"project": "projects/ngx-progressbar/ng-package.json"
137115
},
138116
"configurations": {
139117
"production": {
140-
"devServerTarget": "ngx-progressbar-demo:serve:production"
118+
"tsConfig": "projects/ngx-progressbar/tsconfig.lib.prod.json"
119+
},
120+
"development": {
121+
"tsConfig": "projects/ngx-progressbar/tsconfig.lib.json"
141122
}
123+
},
124+
"defaultConfiguration": "production"
125+
},
126+
"test": {
127+
"builder": "@angular-devkit/build-angular:karma",
128+
"options": {
129+
"tsConfig": "projects/ngx-progressbar/tsconfig.spec.json",
130+
"polyfills": [
131+
"zone.js",
132+
"zone.js/testing"
133+
],
134+
"karmaConfig": "projects/ngx-progressbar/karma.conf.js"
135+
}
136+
},
137+
"lint": {
138+
"builder": "@angular-eslint/builder:lint",
139+
"options": {
140+
"lintFilePatterns": [
141+
"projects/ngx-progressbar/**/*.ts",
142+
"projects/ngx-progressbar/**/*.html"
143+
]
142144
}
143145
}
144146
}
145147
}
148+
},
149+
"cli": {
150+
"schematicCollections": [
151+
"@angular-eslint/schematics"
152+
]
146153
}
147154
}

‎e2e/protractor.conf.js

-32
This file was deleted.

0 commit comments

Comments
 (0)