Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import beta in feature module #234

Closed
olaf89 opened this issue Nov 19, 2018 · 3 comments
Closed

Cannot import beta in feature module #234

olaf89 opened this issue Nov 19, 2018 · 3 comments
Labels

Comments

@olaf89
Copy link

olaf89 commented Nov 19, 2018

What is the expected behavior?

I would like to use Gallery in feature module without importing it in AppModule

What is the current behavior?

In previous version it was possible to import GalleryModule and LightboxModule in feature module and it worked, with latest beta's its not longer possible

The following error is thrown:
TypeError: Cannot read property 'config' of undefined
at new GalleryComponent (ngx-gallery-core.js:694)

What are the steps to reproduce?

Import gallery in feature module

What is the use-case or motivation for changing an existing behavior?

I would like to use gallery in feature module

Which versions are you using for the following packages?

Angular: 7
Angular CDK:7
Angular CLI:7
Typescript:3.16
Gallery: 4.0.0-beta.1

Is there anything else we should know?

@MurhafSousli
Copy link
Owner

Did you try GalleryModule.forRoot() in your lazy module?

@olaf89
Copy link
Author

olaf89 commented Nov 19, 2018

Yes, thats how i have been importing with success in v3

@MurhafSousli
Copy link
Owner

fixed in v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants