Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading icon shows undefined in some cases on mobile #133

Closed
PavolSvidran opened this issue Jul 7, 2018 · 3 comments
Closed

Loading icon shows undefined in some cases on mobile #133

PavolSvidran opened this issue Jul 7, 2018 · 3 comments

Comments

@PavolSvidran
Copy link

PavolSvidran commented Jul 7, 2018

Hi i have issue with loading state of fullscreen gallery. It happens only on mobile devices and i dont know what is bad. I try to simulate it on stackblitz but unsuccessfully. All angular/ng-gallery packages are updated to newest version.
When i open lightbox as soon as possible and there is a lot of pictures with HQ i see undefined in thumbs and sometimes in main screen where is loading animation, then it is changed from undefined to loading animation and then to image.

Is this loading state some svg /icon/image loaded from external resource, is there any style which i can overide and replace loading icon with own and fix this my problem? I dont want hide loading state, i want it but no 'undefined' text.

@MurhafSousli
Copy link
Owner

MurhafSousli commented Jul 7, 2018

@JBeater Please do not remove the issue template next time you open an issue, I need them for tracking purpose. because after a while I cannot remember which version was this issue for.

Did you add thumbnail src path? please show your usage code

@PavolSvidran
Copy link
Author

As i write i cant simulate it at stackblitz, here is preview but you cant see it there: https://stackblitz.com/edit/ngx-gallery-25aj25?file=src%2Fapp%2Fhome%2Fhome.component.ts

Yea i added thumb url, how i write it happens .. undefined -> loading -> image.. so there is maybe problem with loading of loading icon if it is external resource.

@MurhafSousli
Copy link
Owner

Both gallery-item and gallery-thumb use the same component gallery-image which displays the loading icon and then load the image.

The SVG loading icon is not coming from an external source, it is defined in the GalleryConfig as an inline data. which should load immediatly.

The weird thing is that in your screenshot, the loading icon works properly in the gallery-item but shows undefined in gallery-thumb. it just doesn't make sense!

I test it on samsung galaxy S4 chrome and iphone 6 both safari and chrome and I couldn't see the issue.

Anyway, CSS can be used to hide it, see #132

@MurhafSousli MurhafSousli reopened this Jul 7, 2018
@MurhafSousli MurhafSousli changed the title Problems with loading state Loading icon shows undefined in some cases on mobile Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants