Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shortened URLs #82

Open
gpanders opened this issue May 8, 2020 · 1 comment
Open

Allow shortened URLs #82

gpanders opened this issue May 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@gpanders
Copy link

gpanders commented May 8, 2020

Right now, URLs such as

https://amzn.to/2Ve0TZG

will fail the build since it uses a permanent redirect. However, the redirected URL is much longer and uglier, so it is preferable to use the shortened URLs in these cases.

@Munter
Copy link
Owner

Munter commented May 8, 2020

Good point. It probably makes sense to keep the current behavior for internal links, but I can see how external links can have this problem.

I'm not entirely sure how to know if a 301 is from a link shortener or just old content it'll redirects. I'd be happy to hear some ideas about that.

For now you can add a skip it todo match on the failing test to avoid this problem blocking your build

@Munter Munter added the enhancement New feature or request label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants