Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: "retry" parameter #341

Open
fool opened this issue Jan 11, 2021 · 0 comments
Open

feature request: "retry" parameter #341

fool opened this issue Jan 11, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@fool
Copy link

fool commented Jan 11, 2021

This plugin can fail a build unnecessarily, in case there is a transient connection failure from the build network to the resources in question:

11:57:01 AM:   3. onPostBuild command from netlify-plugin-checklinks         
[...]
11:57:34 AM:   ✖ FAIL load https://my-correct-normally-reachable-url
11:57:34 AM:   | operator: load
11:57:34 AM:   | expected: 200 https://my-correct-normally-reachable-url
11:57:34 AM:   |   actual: read ECONNRESET
[...]
────────────────────────────────────────────────────────────────
11:57:34 AM:   Plugin "netlify-plugin-checklinks" failed                     
11:57:34 AM: ────────────────────────────────────────────────────────────────
11:57:34 AM: ​
11:57:34 AM:   Error message
11:57:34 AM:   Error: Links checking failed

This is a failure, no doubt, and unexamined, should fail the build!

But In my use case, the failure is something that likely won't happen on retry and is something that we'd always want to retry at least once. This doesn't happen super often and probably doesn't make sense to enable by default as it could chew through build minutes and cost users money, but it would be nice to have the option in this plugin specifically as something that could be enabled as opt-in.

@Munter Munter added the enhancement New feature or request label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants