Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I increase maximum number of redirects before failing? #159

Open
ComFreek opened this issue Jul 12, 2020 · 4 comments
Open

Can I increase maximum number of redirects before failing? #159

ComFreek opened this issue Jul 12, 2020 · 4 comments

Comments

@ComFreek
Copy link

ComFreek commented Jul 12, 2020

Currently, I am facing the following:

expected: 302 https://dl.acm.org/doi/book/10.5555/1206501 --> 200 https://dl.acm.org/action/cookieAbsent
actual: 302 https://dl.acm.org/doi/book/10.5555/1206501 --> 302 https://dl.acm.org/doi/book/10.5555/1206501?cookieSet=1 --> 200 https://dl.acm.org/action/cookieAbsent

Does it fail due to there being two redirects? If so, can I increase the maximum number of redirects somehow?

@jonmccon
Copy link

jonmccon commented Dec 2, 2020

Same, I would like to up the threshold or if it resolves eventually for external links then pass.

@jonmccon
Copy link

jonmccon commented Dec 2, 2020

Or maybe I'm misunderstanding the todoPatterns when it's saying strings to recognize and ignore. Does that mean specific urls or can I specify a condition like a 302 --> 200

@Munter
Copy link
Owner

Munter commented Dec 2, 2020

@jonmccon You can match any part of the strings you see in the TAP report under name, operator, expected, ´actual, and at`

You can indeed match on 302 --> 200

You can see the super naive implementation of how that pattern is turned into a matcher on the TAP report: https://github.com/Munter/hyperlink/blob/master/lib/cli.js#L132-L139

@jonmccon
Copy link

jonmccon commented Dec 4, 2020

@Munter Thank you! I didn't understand this at first, but now I get it. Setting up the proper exceptions works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants