From 5d8f22f6fefe50a63d29db340125393478fb1910 Mon Sep 17 00:00:00 2001 From: jamieconnelly Date: Mon, 21 Oct 2024 15:48:57 +0300 Subject: [PATCH 1/3] fix: CKEditorError: observable-set-cannot-override see - https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-observable-set-cannot-override --- src/ui/mathview.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/ui/mathview.ts b/src/ui/mathview.ts index e279325..eccf8ff 100644 --- a/src/ui/mathview.ts +++ b/src/ui/mathview.ts @@ -3,8 +3,8 @@ import type { KatexOptions } from '../typings-external.js'; import { renderEquation } from '../utils.js'; export default class MathView extends View { - public value: string; - public display: boolean; + public declare value: string; + public declare display: boolean; public previewUid: string; public previewClassName: Array; public katexRenderOptions: KatexOptions; @@ -38,9 +38,7 @@ export default class MathView extends View { this.previewClassName = previewClassName; this.set( 'value', '' ); - this.value = ''; this.set( 'display', false ); - this.display = false; this.on( 'change', () => { if ( this.isRendered ) { From 7042313bc01991cb5fdff874fe49ef6f8b84eef0 Mon Sep 17 00:00:00 2001 From: jamieconnelly Date: Mon, 21 Oct 2024 15:49:17 +0300 Subject: [PATCH 2/3] chore: bump version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e0b3b18..87dd59f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@multiverse-io/ckeditor5-math", - "version": "43.2.0-next.0", + "version": "43.2.0-next.1", "description": "Math feature for CKEditor 5.", "keywords": [ "ckeditor", From 759263a6a4d1915ea05fff7b0b68bdc4b0921d64 Mon Sep 17 00:00:00 2001 From: jamieconnelly Date: Mon, 21 Oct 2024 15:52:28 +0300 Subject: [PATCH 3/3] chore: update CHANGELOG.md --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1afb08e..12e2cf9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ - Add latest changes here +## [v43.2.0-next.1](https://github.com/Multiverse-io/ckeditor5-math/compare/v43.2.0-next.0...v43.2.0-next.1) (2024-10-21) + +- Fixes `CKEditorError: observable-set-cannot-override` error. See - https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-observable-set-cannot-override + ## [v43.2.0-next.0](https://github.com/Multiverse-io/ckeditor5-math/compare/v43.2.0...v43.2.0-next.0) (2024-10-21) - Bootstrap CI