Skip to content

Unit tests #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamStelmaszczyk opened this issue Jun 21, 2018 · 2 comments
Open

Unit tests #108

AdamStelmaszczyk opened this issue Jun 21, 2018 · 2 comments

Comments

@AdamStelmaszczyk
Copy link

I was looking for unit tests to understand corner cases + see how many of them are to port to C++. I haven't found any unit test of pommerman forward model logic.

It will be good to have at least regression tests when fixing bugs like: b16c395, 3c06283, 8b57431.

@cinjon
Copy link
Collaborator

cinjon commented Jun 21, 2018

Sigh. It's true. We've been very lax on that and haven't put in the effort to build all the proper unit tests. This would be very helpful as a contribution and probably necessary for #103 .

@suphoff
Copy link
Contributor

suphoff commented Aug 4, 2018

Once #123 is resolved recorded (state x action -> state) steps can be repeated by different implementations of step functions and compared with the expected state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants