MudFabMenuItem: Fix link rendering when Href is set#13195
Merged
Conversation
2 tasks
Agent-Logs-Url: https://github.com/MudBlazor/MudBlazor/sessions/1f0c5c7b-8d2e-46c5-a22b-c156141c6c29 Co-authored-by: danielchalmers <7112040+danielchalmers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MudBlazor/MudBlazor/sessions/1f0c5c7b-8d2e-46c5-a22b-c156141c6c29 Co-authored-by: danielchalmers <7112040+danielchalmers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MudFabMenuItem href functionality
Fix May 11, 2026
MudFabMenuItem link rendering when Href is set
MudFabMenuItem link rendering when Href is set
danielchalmers
approved these changes
May 11, 2026
This was referenced May 26, 2026
This was referenced Jun 1, 2026
Closed
Merged
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MudFabMenuItemwas not behaving like other MudBlazor button-like components whenHrefwas assigned. Instead of rendering as a navigable link, it dropped link-related parameters and remained a non-link button.What changed
Href,Target,Rel, and related inherited button parameters fromMudFabMenuItemto the underlyingMudFab.MudFablink behavior soMudFabMenuItemnow renders as an anchor when appropriate, including_blank+ defaultnoopenerhandling.Behavioral impact
MudFabMenuItemnow follows the same link semantics asMudButton,MudFab, and similar components.Target,Rel, and anchor rendering work together instead of being silently ignored.Regression coverage
MudFabMenuItemwithHrefrenders as<a>and emits the expectedhref,target, andrelattributes.Example
This now renders the menu item as a clickable anchor and preserves the expected link attributes.