Skip to content

Conversation

@charles7668
Copy link
Contributor

Description

Close #9855

How Has This Been Tested?

Add test case in DataMaskTests.DataMask2

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Dec 3, 2024
@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (ff672a8) to head (d41e61a).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10377      +/-   ##
==========================================
+ Coverage   91.43%   91.49%   +0.06%     
==========================================
  Files         418      418              
  Lines       13226    13222       -4     
  Branches     2538     2536       -2     
==========================================
+ Hits        12093    12098       +5     
+ Misses        554      549       -5     
+ Partials      579      575       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles7668 charles7668 marked this pull request as draft December 3, 2024 06:55
@charles7668 charles7668 force-pushed the Fix02-29NotAllowAfterYearInputOnce branch from 0eb9629 to d41e61a Compare December 3, 2024 07:36
@charles7668 charles7668 marked this pull request as ready for review December 3, 2024 07:50
@ScarletKuro ScarletKuro requested a review from henon December 3, 2024 11:30
return -1;
return 0;
if (int.TryParse(yearString, out var y))
return (DateTime.Today.Year / 100 * 100) + y; // this code will still work in 2100 until 2900. I guess in a thousand years we'll have to update this line ;)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

@henon henon changed the title DateMask: Fix #9855 : Resolve 02/29 with DateMask DateMask: Fix leap year February logic 02/29 Dec 6, 2024
@henon henon merged commit a108c82 into MudBlazor:dev Dec 6, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented Dec 6, 2024

Thanks @charles7668 , I see you are on a fixing spree ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DateMask Leap Year Logic Remembers Last Typed Year

2 participants