Add product delete endpoint

Author: MrBartusek

apps/api/src/models/products/products.controller.ts

@@ -6,18 +6,19 @@ import {
 	NotFoundException,
 	Param,
 	Post,
+	Put,
 	UseGuards,
 	ValidationPipe,
-	Put,
+	Delete,
 } from '@nestjs/common';
 import { ApiTags } from '@nestjs/swagger';
-import mongoose, { Types } from 'mongoose';
+import { Types } from 'mongoose';
 import { BasicProductDto, CreateProductDto, ProductDto, UpdateProductDto } from 'shared-types';
 import { AuthenticatedGuard } from '../../auth/guards/authenticated.guard';
+import { ParseObjectIdPipe } from '../../pipes/prase-object-id.pipe';
 import { OrganizationsStatsService } from '../organizations/organizations-stats.service';
 import { ProductsService } from './products.service';
 import { Product } from './schemas/product.schema';
-import { ParseObjectIdPipe } from '../../pipes/prase-object-id.pipe';
 
 @ApiTags('products')
 @Controller('products')
@@ -45,12 +46,6 @@ export class ProductsController {
 		return Product.toDto(product);
 	}
 
-	@Get('by-org/:id')
-	async findAll(@Param('id', ParseObjectIdPipe) id: Types.ObjectId): Promise<BasicProductDto[]> {
-		const products = await this.productsService.findAll(id);
-		return products.map((product) => Product.toBasicDto(product));
-	}
-
 	@Put(':id')
 	async update(
 		@Param('id', ParseObjectIdPipe) id: Types.ObjectId,
@@ -63,6 +58,21 @@ export class ProductsController {
 		return Product.toDto(product);
 	}
 
+	@Delete(':id')
+	async delete(@Param('id', ParseObjectIdPipe) id: Types.ObjectId): Promise<ProductDto> {
+		const product = await this.productsService.delete(id);
+		if (!product) {
+			throw new NotFoundException();
+		}
+		return Product.toDto(product);
+	}
+
+	@Get('by-org/:id')
+	async findAll(@Param('id', ParseObjectIdPipe) id: Types.ObjectId): Promise<BasicProductDto[]> {
+		const products = await this.productsService.findAll(id);
+		return products.map((product) => Product.toBasicDto(product));
+	}
+
 	async updateTotalProductsCount(organizationId: Types.ObjectId) {
 		const newCount = await this.productsService.countAll(organizationId);
 		await this.organizationStatsService.updateProductsCount(organizationId, newCount);

apps/api/src/models/products/products.service.ts

@@ -19,6 +19,10 @@ export class ProductsService {
 		return this.productsRepository.findOneByIdAndUpdate(id, dto);
 	}
 
+	delete(id: mongoose.Types.ObjectId): Promise<ProductDocument> {
+		return this.productsRepository.deleteOneById(id);
+	}
+
 	exist(id: Types.ObjectId) {
 		return this.productsRepository.exist({ _id: id });
 	}