From 7e67f9143ade3a700560fd2cd8c36208f5499865 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Mon, 21 Aug 2023 13:54:42 -0700 Subject: [PATCH] Recommend a default size of 1 for the SimpleFixedSizeExemplarReservoir This reservoir type is used for all aggregations other than a histogram with more than one bucket. Each attribute set the aggregation records will have reservoir. Therefore, limiting this to a small value by default when enabled is preferable. This does not address the way a user will configure this value. That is left for a future PR/Issue. Part of #2421 --- specification/metrics/sdk.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 371987b7b38..5d71a8637c5 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -1033,7 +1033,8 @@ cycle. For the above example, that would mean that the `num_measurements_seen` count is reset every time the reservoir is collected. This Exemplar reservoir MAY take a configuration parameter for the size of the -reservoir pool. +reservoir pool. If no size configuration is provided, the default size of `1` +SHOULD be used. #### AlignedHistogramBucketExemplarReservoir